-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open response assesment detail (problem steps) UI #5
base: master
Are you sure you want to change the base?
Conversation
8713a74
to
0080e16
Compare
0080e16
to
980069b
Compare
@@ -18,7 +18,7 @@ const messages = defineMessages({ | |||
}, | |||
idAssessmentColumnTitle: { | |||
id: 'ora-grading.ReviewProblemStepsContent.idAssessmentColumnTitle', | |||
defaultMessage: 'ID Assessment', | |||
defaultMessage: 'Assessment ID', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you changing this? The mockup in the Figma doesn't look like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the API it is returned as assessment_id
, I modified it for consistency. But it could be left as it looks in the mockup.
let data; | ||
if (feedbackListType === 'received') { | ||
data = await api.getFeedbackFromList(submissionUUID); | ||
} else { | ||
data = await api.getFeedbackToList(submissionUUID); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion: If we had more options this way I could add more promises
const feedbackListTypesResponses = {
'received': api.getFeedbackFromList(submissionUUID),
'given': api.getFeedbackToList(submissionUUID),
};
const response = feedbackListTypes[feedbackListType] || Promise.resolve({ assessments: [] });
const data = await response;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! Done
Hi there @BryanttV! Thanks for doing this. I left a couple of minor comments. Probably this will need some tests I will be cheking out that later |
343da29
to
fb2727b
Compare
5659b56
to
e76429c
Compare
e76429c
to
aba4c7f
Compare
aba4c7f
to
1b9fa9d
Compare
Description
This PR allows us to see in detail each step of an open response, which means Training, Peer, Self, and Staff, and can also see feedback received and feedback given.
Responses List
Assessments Feedback Received
Assessments Feedback Given
Here's what you see in the video explained:
Why are we proposing these changes?
This improvement enables instructors to access detailed information for each Open Response, making it easier for them to review ORA responses and maintain better control over the feedback process.
Dependencies
initialize
endpoint and createassessments/feedback
endpoint in ORA Staff Grader openedx/edx-platform#33632 (Merged)initialize
endpoint and createassessments/feedback
endpoint in ORA Staff Grader openedx/edx-ora2#2101 (Merged)Testing Instructions
Using Tutor:
nvm use && npm install
tutor mounts add frontend-app-course-authoring
tutor dev start -d
to create the new container of ORA Grading.