fix: video crashes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafqat-muneer
approved these changes
Aug 22, 2024
forgotvas
requested changes
Aug 22, 2024
| @@ -72,7 +72,11 @@ public class VideoPlayerViewModel: ObservableObject { | |||
|
|
|||
| playerHolder.getTimePublisher() | |||
| .sink {[weak self] time in | |||
| self?.currentTime = time | |||
| if time.isNaN { | |||
There was a problem hiding this comment.
Better to move that condition to PlayerHolder where publisher send time value
forgotvas
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
LGTM, but what do you think about to add same check to 138 line inside addPeriodicTimeObserver closure:
private func observe() {
....
timeObserver = player?.addPeriodicTimeObserver(forInterval: interval, queue: .main) {[weak self] time in
self?.timePublisher.send(time.seconds)
}
It's a PeriodicTimeObserver so it will only call when there is any change in the video playback and in that case the value shouldn't be nan. |
ok i just not sure that this closure will always have correct value. If you are sure then ok. |
saeedbashir
added a commit
that referenced
this pull request
Aug 23, 2024
rnr
added a commit
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App was crashing in two cases of videos, both the crashes can be tested on course
Project Management for DevelopmentHow it can be tested:
It can be tested on the first section,
Start here->0.1 Welcome to the course-> going to the videoSolution:
Mimic the behaviour from the old app.
2. When the LMS returns wrong data for transcripts, LSM is returning less time for endtime than the starttime of the transcript.
How it can be tested:
1. Go to Videos tab
2. Go to Module 1: Project Chapter
3. Go to 1.1.5 Video: Project Chapter (can be selected from the dropdown switcher)
4. Go to the video component