Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time awk and wget/curl unnecessarily required to build build-recorder #205

Open
fvalasiad opened this issue Aug 9, 2023 · 2 comments
Open

time awk and wget/curl unnecessarily required to build build-recorder #205

fvalasiad opened this issue Aug 9, 2023 · 2 comments
Labels
invalid This doesn't seem right

Comments

@fvalasiad
Copy link
Collaborator

Title, those are dependencies for the benchmark folder, yet building build-recorder will complain about em missing.

Users are free to not run tests, and this could become an issue if we add more targets written in other languages such as rust. What's gonna happen then, will users be forced to install cargo just to build build-recorder?

Additionally, make benchmark needs to go, and instead be replaced by single names such as
make hello
make wine
make linux

Or whatever. Including make all for those who want to run every test.
@fvalasiad fvalasiad added the invalid This doesn't seem right label Aug 9, 2023
fvalasiad added a commit to fvalasiad/build-recorder that referenced this issue Aug 30, 2023
@fvalasiad
configure.ac: Add option to configure script for benchmarks.
4e8ae6a 
As discussed in eellak#205, this commit makes it so
that building the benchmark directory is optional
and disabled by default. I'd argue opt-in is superior
in our case since benchmarks are only relevant to the
developers of this project.

This allows us to add a as many dependencies to benchmark
as we possibly want or need, without minding the extra
dependencies that we add to the project.

We still have to face the fact that different benchmark
targets have different dependencies and perhaps we'd want
to provide options for each separate benchmark but I find
this too complicated.

Signed-off-by: Fotios Valasiadis <[email protected]>
@fvalasiad fvalasiad mentioned this issue Aug 30, 2023
Open
@Jyoticharan
Copy link

please assign me this issue

@zvr
Copy link
Collaborator

zvr commented Dec 3, 2023

I have a hard time imagining a running Linux system which misses these...

@fvalasiad fvalasiad mentioned this issue Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zvr @fvalasiad @Jyoticharan