Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group event and side effect in trace tab #29

Open
ilyaagarkov opened this issue Jan 13, 2022 · 1 comment
Open

Group event and side effect in trace tab #29

ilyaagarkov opened this issue Jan 13, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ilyaagarkov
Copy link
Member

Version 0.8 with trace tab looks amazing!

But what if we could see logs grouped not by a tick but grouped by event with all side effects this event run

as example

const event1 = createEvent();
const event2 = createEvent();

const effect = createEffect(() => {});

forward({
 from: event1,
  to: effect
})

event1();
event2()

show something like this

event `event1` triggered
  effect `effect` triggered
  event `effect.done` triggered


event `event2`  triggered
@AlexandrHoroshih
Copy link
Member

Looks like it can result in a very long trace in some cases 🤔
e.g. long-polling cycles or something like that

Should this be somehow detected or filtered?

event `event1` triggered
  25 times:
  effect `effect` triggered
  event `effect.done` triggered
  -> cycle: effect 'effect' triggered

@sergeysova sergeysova added enhancement New feature or request help wanted Extra attention is needed labels Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants