Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the rebase-exec exercise a little more intuitive #242

Open
praqma-thi opened this issue Apr 29, 2020 · 0 comments · May be fixed by #374
Open

Make the rebase-exec exercise a little more intuitive #242

praqma-thi opened this issue Apr 29, 2020 · 0 comments · May be fixed by #374

Comments

@praqma-thi
Copy link

The scenario painted in the rebase-exec exercise is a little counter-intuitive. The commits we're rebasing add a bunch of text files, but we never interact with them. One of the commits breaks the test script, which we then need to fix by basically undoing the changes to the test script.

Perhaps moving to a scenario where the test file actually tests a different script which the commits modify would be a little more intuitive.


I'm not sure how we could achieve this yet. My original suggestion was having a script called zero.sh which does some simple math and exits with the result, e.g. exit (2 - 1 -1), and have test.sh just:

echo "Asserting zero.sh exits 0.
./zero.sh
exit $?

The commits being rebased could then modify the zero.sh script, the breaking commit making the math not end up at 0.

It's also an arcane scenario, but perhaps a little more intuitive.

ChandanChainani added a commit to ChandanChainani/git-katas that referenced this issue Oct 3, 2024
@ChandanChainani ChandanChainani linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants