Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for functions that interact with a send server #7

Open
ehuggett opened this issue Nov 9, 2017 · 0 comments
Open

Write tests for functions that interact with a send server #7

ehuggett opened this issue Nov 9, 2017 · 0 comments

Comments

@ehuggett
Copy link
Owner

ehuggett commented Nov 9, 2017

none of the api_* functions currently have any tests.

  • Something like https://pypi.python.org/pypi/requests-mock may be of use here
  • Running the tests against a local send server would give more meaningful results
    • might make the tests harder to run (as they will now require Send and all of its dependencies).
    • tests would probably have to be run in a specific order and may become dependant upon each other (ie upload before download, and download would need the url created by upload)
    • A send server can be started within Travis, it seems unlikely the Firefox Send project would want my tests being run against their service

It would be very interesting to attempt to ensure compatibility with the official client by using https://developer.mozilla.org/en-US/Firefox/Headless_mode#Automated_testing_with_headless_mode (upload with browser + download with send-cli and vice versa), there are some tests in Firefox Send that may be relevant/reusable here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant