Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SubscriptionRepository package #420

Open
henning-roos opened this issue Jan 15, 2020 · 0 comments
Open

Remove SubscriptionRepository package #420

henning-roos opened this issue Jan 15, 2020 · 0 comments
Labels
code improvements Improvements to make the code base more readable and manageable.

Comments

@henning-roos
Copy link
Member

Description

Remove the classes in "repository" package (SubscriptionRepository + ISubscriptionRepository) and move the code into SubscriptionService class.

Motivation

Remove extra unnecessary layer of calls. The SubscriptionService is already hard coded towards using MongoDB (with MongoQuery) so the extra abstraction doesn't provide any value. MongoDBHandler is used directly by other classes, bypassing the SubscriptionRepository...

Exemplification

Not applicable.

Benefits

Easier to follow the code. Could be more easily refactored in the future (interface towards database).

Possible Drawbacks

Will not improve functionality but rather readability of code.
@henning-roos henning-roos added the code improvements Improvements to make the code base more readable and manageable. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code improvements Improvements to make the code base more readable and manageable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henning-roos