Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup confirmation is timezone dependant #5

Open
randomstatistic opened this issue Jul 14, 2016 · 0 comments
Open

Backup confirmation is timezone dependant #5

randomstatistic opened this issue Jul 14, 2016 · 0 comments

Comments

@randomstatistic
Copy link
Contributor

If solrcloud_manager is being run in a different timezone than the SolrCloud servers, solrcloud_manager may fail to determine that a backup is complete for up to 24 hours.
This is because it records a timestamp locally, just before the backup command is issued, and waits until a SolrCloud-reported timestamp of the last completed backup is greater than that.

Seems like this should be changed to get the last completed backup time before the backup command starts, and use that instead of a local timestamp. (If there isn't one, some timestamp in the 1970s should probably suffice.)
This requires an extra request, but would ensure the timestamps are all from the cluster's perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant