Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lint:ignore in modeldecoder/generator/slice.go #131

Closed
dmathieu opened this issue Jul 28, 2023 · 0 comments · Fixed by #145
Closed

Remove lint:ignore in modeldecoder/generator/slice.go #131

dmathieu opened this issue Jul 28, 2023 · 0 comments · Fixed by #145

Comments

@dmathieu
Copy link
Member

Update the modeljson generator to remove the redundant minValue check from the generated Go code for unsigned integers, while keeping the validation in the generated JSON schema.

So we can remove the nolint in https://github.com/elastic/apm-data/blob/main/input/elasticapm/internal/modeldecoder/generator/slice.go

See #123 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove minvals check for uints kruskall/apm-data
1 participant
@dmathieu