Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate switching error grouping key calculation to use something faster #146

Open
axw opened this issue Jan 22, 2020 · 4 comments
Open

Comments

@axw
Copy link
Member

axw commented Jan 22, 2020

We should investigate switching from MD5 to something faster, like xxhash, for calculating error grouping keys. MD5 is cryptographic, which is not necessary for our purposes. xxHash is non-cryptographic, and considerably faster while maintaining high quality hashes.

@graphaelli
Copy link
Member

Let's consider adding a feature flag during 7.x for users to opt in to this, based on how big of a change this ends up being.

@axw axw changed the title Investigate switching error grouping key calculation to use xxhash Investigate switching error grouping key calculation to use something faster Nov 16, 2020
@axw
Copy link
Member Author

axw commented Nov 16, 2020

If we move source mapping to an ingest node pipeline (elastic/apm-server#3606), then xxhash may not be a sensible option. We might be able to use murmur3, however this is provided by a plugin and may not be available.

@axw
Copy link
Member Author

axw commented Nov 17, 2020

@kruskall
Copy link
Member

The implementation now lives at https://github.com/elastic/apm-data/blob/main/model/modelprocessor/groupingkey.go

I'll move this to the apm-data repository

@kruskall kruskall transferred this issue from elastic/apm-server Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants