-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate switching error grouping key calculation to use something faster #146
Comments
Let's consider adding a feature flag during 7.x for users to opt in to this, based on how big of a change this ends up being. |
If we move source mapping to an ingest node pipeline (elastic/apm-server#3606), then xxhash may not be a sensible option. We might be able to use |
Related Elasticsearch issues, proposing new ingest node processor functionality: |
The implementation now lives at https://github.com/elastic/apm-data/blob/main/model/modelprocessor/groupingkey.go I'll move this to the apm-data repository |
We should investigate switching from MD5 to something faster, like xxhash, for calculating error grouping keys. MD5 is cryptographic, which is not necessary for our purposes. xxHash is non-cryptographic, and considerably faster while maintaining high quality hashes.
The text was updated successfully, but these errors were encountered: