Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async processing #193

Closed
kruskall opened this issue Dec 18, 2023 · 1 comment · Fixed by #197
Closed

remove async processing #193

kruskall opened this issue Dec 18, 2023 · 1 comment · Fixed by #197

Comments

@kruskall
Copy link
Member

non-blocking ingest behaviour was added because of elastic/apm-server#7872 to be used in the lambda extension.

It was never implemented and apm-server has improved since then. Recently there was some discussion around sync/async and it was proposed to remove it since we are not using it and it's just additional complexity.

cc @axw for feedback since you opened the initial issue

@axw
Copy link
Member

axw commented Dec 20, 2023

Given that we never actually made use of it, and the general thrust behind treating OpenTelemetry as first class citizen (with no way to have those clients request such behaviour), I'm good with removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants