Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map OTLP HTTP request and response headers #285

Open
stevejgordon opened this issue Jun 4, 2024 · 5 comments
Open

Map OTLP HTTP request and response headers #285

stevejgordon opened this issue Jun 4, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@stevejgordon
Copy link
Contributor

Per the OTel semantic conventions, client and server HTTP spans may send the request and response headers using the following attributes:

  • http.request.header.<key>
  • http.response.header.<key>

We don't currently map these in traces.go onto the modelpb.HTTPRequest.Headers and modelpb.HTTPResponse.Headers. As a result, if these are included in the span attributes, they are mapped onto labels.* which is not ideal.

image

These should ideally be mapped to our APM model.

@simitt
Copy link
Contributor

simitt commented Sep 9, 2024

@stevejgordon any chance you could pick this up at some time?

@stevejgordon
Copy link
Contributor Author

@simitt I'd like to try to tackle this. It won't be earlier than next week, though, as I have some other competing work items.

@simitt
Copy link
Contributor

simitt commented Sep 27, 2024

@stevejgordon do you still plan to tackle this for 8.16.0?

@stevejgordon
Copy link
Contributor Author

@simitt Unfortunately, other priorities in the agent have kept me from getting to this. I probably won't have time in the next few weeks, so if someone else can tackle it, it would be great to have it in for 8.16. Otherwise, I can try to get to it sometime in mid-late October.

@simitt
Copy link
Contributor

simitt commented Sep 27, 2024

got it, I believe we need to push it out in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants