-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map OTLP HTTP request and response headers #285
Comments
@stevejgordon any chance you could pick this up at some time? |
@simitt I'd like to try to tackle this. It won't be earlier than next week, though, as I have some other competing work items. |
@stevejgordon do you still plan to tackle this for |
@simitt Unfortunately, other priorities in the agent have kept me from getting to this. I probably won't have time in the next few weeks, so if someone else can tackle it, it would be great to have it in for 8.16. Otherwise, I can try to get to it sometime in mid-late October. |
got it, I believe we need to push it out in this case. |
Per the OTel semantic conventions, client and server HTTP spans may send the request and response headers using the following attributes:
http.request.header.<key>
http.response.header.<key>
We don't currently map these in
traces.go
onto themodelpb.HTTPRequest.Headers
andmodelpb.HTTPResponse.Headers
. As a result, if these are included in the span attributes, they are mapped ontolabels.*
which is not ideal.These should ideally be mapped to our APM model.
The text was updated successfully, but these errors were encountered: