Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align on and rename repository and helm chart name #52

Closed
simitt opened this issue Sep 9, 2022 · 10 comments
Closed

Align on and rename repository and helm chart name #52

simitt opened this issue Sep 9, 2022 · 10 comments
Assignees
Labels
Milestone

Comments

@simitt
Copy link
Contributor

simitt commented Sep 9, 2022

Current names:

  • Repo: apm-mutating-webhook: it is defining what it is rather than what it does. Knowledge that this is a mutating webhook is not required for usage, and should be treated as an implementation detail, rather than being surfaced in the name.
  • Helm: apm-agent-auto-attach: too verbous; focus only on apm-agents, where longer term it might contain something related to apm-server?

Suggestions:

Everyone who wants to suggest a name, please update the list below. @chrisdistasio @alex-fedotyev would appreciate your inputs.

Repo

suggestion comment actively considered
apm-k8s-attacher keep aligned with apm prefix, mention k8s yes

Helm

suggestion comment actively considered
apm-attacher k8s would be redundant for helm chart yes
@simitt
Copy link
Contributor Author

simitt commented Sep 14, 2022

@felixbarny @axw @Mpdreamz @AlexanderWert @alex-fedotyev @chrisdistasio @graphaelli any concerns about the suggested names?
If not, I suggest we move forward with them by tomorrow, to unblock Marc from recording the screencast with the new names.

@simitt simitt modified the milestones: GA, 8.6 Sep 23, 2022
@simitt simitt changed the title Align on repository and helm chart name Align on and rename repository and helm chart name Sep 23, 2022
@simitt
Copy link
Contributor Author

simitt commented Sep 23, 2022

We settled on the names apm-k8s-attacher and apm-attacher. Next steps are to rename the repository and the helm chart.

@simitt simitt added the v8.6.0 label Oct 4, 2022
@simitt simitt removed this from the 8.6 milestone Feb 24, 2023
@felixbarny felixbarny added this to the GA milestone Apr 4, 2023
@jackshirazi
Copy link
Contributor

The helm name was changed (not sure when)

$ helm search repo
NAME                            CHART VERSION   APP VERSION     DESCRIPTION
elastic/apm-attacher            0.1.0                           A Helm chart installing the Elastic APM mutatin...

Who has permission to change the repo name?

@simitt
Copy link
Contributor Author

simitt commented Dec 6, 2023

Who has permission to change the repo name?

That should be the @elastic/observablt-robots team.

@jackshirazi
Copy link
Contributor

Repo name has been changed. I've updated the doc links in #84 . After that is merged we need a new release with a version increment, and then I'll test it's all working and the docs are correct. Not sure how to do a release here - probably worth updating the release section in the README

@jackshirazi
Copy link
Contributor

jackshirazi commented Dec 7, 2023

Note that the last release (v0.2.0) didn't update the charts at elastic helm:

$ helm repo add elastic https://helm.elastic.co
$ helm search repo
NAME                            CHART VERSION   APP VERSION     DESCRIPTION
elastic/apm-attacher            0.1.0                           A Helm chart installing the Elastic APM mutatin...

presumably because the chart is still saying 0.1.0

@estolfo
Copy link
Contributor

estolfo commented Dec 21, 2023

Here are some outstanding rename tasks:

@trentm
Copy link
Member

trentm commented Dec 21, 2023

Here are some outstanding rename tasks:
...

These from doing this search: https://github.com/search?q=org%3Aelastic%20apm-mutating-webhook&type=code
(I suppose the results from that might differ based on repo access permissions.)

Two of @amannocci's PRs are not yet merged, which covers a few of these search hits.

@trentm
Copy link
Member

trentm commented Jan 17, 2024

There are still a few remaining code hits for https://github.com/search?q=org%3Aelastic%20apm-mutating-webhook&type=code but nothing that impacts users. I think this renaming is complete.

@trentm trentm closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants