feat: tag latest container image #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
reviewed
Mar 13, 2024
Comment on lines
69
to
+71
| docker push $(IMAGE_REF) | ||
| docker tag $(IMAGE_REF) $(CONTAINER_IMAGE_BASE_REF):latest | ||
| docker push $(CONTAINER_IMAGE_BASE_REF):latest |
There was a problem hiding this comment.
nit:
Suggested change
| docker push $(IMAGE_REF) | |
| docker tag $(IMAGE_REF) $(CONTAINER_IMAGE_BASE_REF):latest | |
| docker push $(CONTAINER_IMAGE_BASE_REF):latest | |
| docker tag $(IMAGE_REF) $(CONTAINER_IMAGE_BASE_REF):latest | |
| docker push --all-tags $(CONTAINER_IMAGE_BASE_REF) |
-a, --all-tags Push all tags of an image to the repository
v1v
approved these changes
Mar 13, 2024
reakaleek
approved these changes
Mar 13, 2024
kruskall
approved these changes
Mar 13, 2024
Signed-off-by: Adrien Mannocci <[email protected]>
amannocci
force-pushed
the
feat/tag-latest
branch
from
0ab18f2
to
ce8d963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change being made?
Why is the change being made?