Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logstash docs to object notation for data_stream #11917

Closed
simitt opened this issue Oct 23, 2023 · 3 comments · Fixed by #12084
Closed

Update logstash docs to object notation for data_stream #11917

simitt opened this issue Oct 23, 2023 · 3 comments · Fixed by #12084
Assignees
Labels
Milestone

Comments

@simitt
Copy link
Contributor

simitt commented Oct 23, 2023

Since elastic/apm-data#124 the apm-server sends the data_stream information in object notation rather than dotted fields. This aligns better with logstash expectations.

Update the logstash guide to remove the mutate filter as it is not necessary anymore.

@simitt simitt added the docs label Oct 23, 2023
@simitt simitt added this to the 8.10 milestone Oct 23, 2023
@lucabelluccini
Copy link
Contributor

Thanks Silvia.
I would "keep it" but just prepend it with a "if you're using a previous version of APM Server, please add this mutate filters..." or the like to guarantee some backward compatibility for mixed versions.

@simitt
Copy link
Contributor Author

simitt commented Oct 24, 2023

The docs for previous versions would still contain the section, but the docs since 8.10, where the behavior changed wouldn't. IMO it'd be more confusing to discuss workarounds in a version where they are not relevant anymore.

@bmorelli25
Copy link
Member

bmorelli25 commented Nov 8, 2023

@colleenmcginnis, sorry for not seeing this earlier. Would've been super easy to add this onto #11989.

There's another Logstash update requested in #11651. Could probably update both in a single PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants