Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove apm_user role #14876

Merged
merged 3 commits into from
Dec 27, 2024
Merged

tests: remove apm_user role #14876

merged 3 commits into from
Dec 27, 2024

Conversation

endorama
Copy link
Member

@endorama endorama commented Dec 9, 2024

Motivation/summary

The apm_user role was removed from Kibana elastic/elasticsearch#116712

The role is deprecated since 7.13.

Checklist

How to test these changes

TBD

Related issues

Closes #14859

@endorama endorama requested a review from a team as a code owner December 9, 2024 17:37
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 9, 2024
1pkg
1pkg previously approved these changes Dec 9, 2024
View reviewed changes
@endorama endorama force-pushed the remote-testing-es-role branch from 8d99d6d to 69217d5 Compare December 23, 2024 16:00
@kruskall kruskall requested a review from a team December 24, 2024 16:03
@kruskall kruskall added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Dec 24, 2024
@endorama endorama mentioned this pull request Dec 27, 2024
Open
@endorama
Copy link
Member Author

As found out with this PR this may have customer impact. I opened a documentation issue elastic/observability-docs#4718 to have the documentation updated with the additional permissions for TBS use case.

@kruskall kruskall merged commit ef6f0c6 into main Dec 27, 2024
11 checks passed
@kruskall kruskall deleted the remote-testing-es-role branch December 27, 2024 12:29
@simitt
Copy link
Contributor

simitt commented Jan 2, 2025

@endorama please add a changelog entry for the breaking changes in apm-server for 9.0 for this.

@endorama
Copy link
Member Author

endorama commented Jan 9, 2025

@simitt PR up #15197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubvs rubvs rubvs approved these changes

@1pkg 1pkg 1pkg left review comments

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove apm_user from testing user roles
5 participants
@endorama @simitt @1pkg @rubvs @kruskall