-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build 149 for 8.8 with status FAILURE - FAIL: x-pack/libbeat/management TestInputReload (20.01s) #36192
Comments
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
@belimawr did we do something to fix this one on 8.9 branch and main? |
There is a race condition on this tests, I have a PR open to fix this: #36185 I started a small thread about whether we should remove this test or not, there is an integration test that covers the same feature, so I believe it is safe to remove it. I'll update the PR today removing this flaky test. |
#36185 is ready for review! |
This commit fixes a number of race conditions in the ManagerV2 tests. Most of them were due to the use of Testify's Eventually function to read some values while some callbacks from the manager would also modify those values. The simplest solution was to use the atomic values on those cases. One test (TestInputReload) had a race condition between the test and the manager itself, so it was removed. There is an integration tests that covers the same functionality. Closes #36192
This commit fixes a number of race conditions in the ManagerV2 tests. Most of them were due to the use of Testify's Eventually function to read some values while some callbacks from the manager would also modify those values. The simplest solution was to use the atomic values on those cases. One test (TestInputReload) had a race condition between the test and the manager itself, so it was removed. There is an integration tests that covers the same functionality. Closes #36192 (cherry picked from commit 818c72d)
This commit fixes a number of race conditions in the ManagerV2 tests. Most of them were due to the use of Testify's Eventually function to read some values while some callbacks from the manager would also modify those values. The simplest solution was to use the atomic values on those cases. One test (TestInputReload) had a race condition between the test and the manager itself, so it was removed. There is an integration tests that covers the same functionality. Closes #36192 (cherry picked from commit 818c72d) Co-authored-by: Tiago Queiroz <[email protected]>
This commit fixes a number of race conditions in the ManagerV2 tests. Most of them were due to the use of Testify's Eventually function to read some values while some callbacks from the manager would also modify those values. The simplest solution was to use the atomic values on those cases. One test (TestInputReload) had a race condition between the test and the manager itself, so it was removed. There is an integration tests that covers the same functionality. Closes elastic#36192
💔 Build Failed
Expand to view the summary
Build stats
Start Time: 2023-08-01T08:19:19.570+0000
Duration: 127 min 53 sec
Test stats 🧪
Steps errors
Expand to view the steps failures
x-pack/libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest
mage build unitTest
Google Storage Download
[2023-08-01T09:59:05.366Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs:
The text was updated successfully, but these errors were encountered: