Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Metricset metrics client allow overriding the endpoint #40848

Closed
alexsapran opened this issue Sep 16, 2024 · 2 comments · Fixed by #40918
Closed

[GCP] Metricset metrics client allow overriding the endpoint #40848

alexsapran opened this issue Sep 16, 2024 · 2 comments · Fixed by #40918
Assignees
Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Comments

@alexsapran
Copy link
Contributor

The GCP metricset metric as I was looking at

client, err := monitoring.NewMetricClient(ctx, m.config.opt...)

We are not able to override the api endpoint. It would be good to be able to do that if we want to test against a fake GCP API endpoint.

Looking at the source code of the client https://github.com/googleapis/google-cloud-go/blob/4265accaab624984d7ea60025e24198a0a0db6d3/monitoring/apiv3/metric_client.go#L55 it looks it gives us the ability to define the option option.WithEndpoint(...)

Preferably, it would be good to override with some env var.

This will be useful in the effort we are starting with doing performance work for metricbeat.

Not sure which team is more suited for this ask; I am just pinging both teams from the codeowners
@elastic/obs-ds-hosted-services or @elastic/obs-infraobs-integrations

Sorry for the noise. If you feel you are in the wrong group or the file is not up-to-date.

/cc @cachedout @ablnk

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 16, 2024
@alexsapran alexsapran added Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Sep 16, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 16, 2024
@graphaelli
Copy link
Member

@lalit-satapathy can you help with this one?

@lalit-satapathy
Copy link
Contributor

@lalit-satapathy can you help with this one?

Hi @Linu-Elias, Can you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants