Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up fsnotify module dependency #40921

Closed
leehinman opened this issue Sep 20, 2024 · 2 comments
Closed

clean up fsnotify module dependency #40921

leehinman opened this issue Sep 20, 2024 · 2 comments
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@leehinman
Copy link
Contributor

Currently go.mod claims that beats requires fsnotify 1.6.0

github.com/fsnotify/fsnotify v1.6.0

This is because containerd v1.7.20 requires that version. However, farther down in go.mod fsnotify is replaced with

github.com/fsnotify/fsnotify => github.com/adriansr/fsnotify v1.4.8-0.20211018144411-a81f2b630e7c

This means that all versions of fsnotify will be replaced with the one specified, which is really based on v1.4.7, further complicating things the go.mod in github.com/adriansr/fsnotify contains the following:

require (
        github.com/fsnotify/fsnotify v1.5.1
        golang.org/x/sys v0.0.0-20211007075335-d3039528d8ac
)

Which means you always get v1.5.1, even if you try to specify the exact version that adriansr/fsnotify provides. This is a complicated mess. And means that any code that uses features that are only found in 1.6.0 won't be able to find the code.

Propose the following fix.

  1. Elastic should create a new repo for a fsnotify fork, and merge in the 2 changes that are in the adriansr fork
  2. Elastic should release a 1.6.0 version and 1.7.0 version of fsnotify with the 2 changes
  3. Elastic should work on getting these changes in upstream so we don't have to maintain a fork
@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 20, 2024
@leehinman leehinman self-assigned this Sep 20, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert
Copy link
Collaborator

Closing as #40956 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

3 participants