Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TQDM progress bar for Jupyter Notebook pandas_to_eland() calls #294

Open
sethmlarson opened this issue Oct 19, 2020 · 2 comments · May be fixed by #299
Open

Add TQDM progress bar for Jupyter Notebook pandas_to_eland() calls #294

sethmlarson opened this issue Oct 19, 2020 · 2 comments · May be fixed by #299
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Solution is fleshed out and ready to be worked on

Comments

@sethmlarson
Copy link
Contributor

  • https://github.com/tqdm/tqdm#ipythonjupyter-integration
  • Units are rows/s
  • Maybe hide progress bar on completion? Need to test it out first.
  • Add an option show_progressbar which defaults to None
    • If None show a progress bar only if we detect Jupyter Notebook
    • If False don't show a progress bar
    • If True show a progress bar only if we detect Jupyter Notebook (for now)
@sethmlarson sethmlarson added enhancement New feature or request help wanted Solution is fleshed out and ready to be worked on good first issue Good for newcomers labels Oct 19, 2020
@V1NAY8
Copy link
Contributor

V1NAY8 commented Oct 21, 2020

I'll try to implement this and get a gif to show for you. 😬

@V1NAY8
Copy link
Contributor

V1NAY8 commented Oct 24, 2020 •
edited
Loading

@sethmlarson
I tried an example in jupyter notebook

ezgif com-gif-maker

Need suggestion on this:

  • from tqdm.notebook import tqdm => It only works in jupyter notebook , not in jupyter lab, terminal

In jupyter lab, It throws the following:
image

I had the same scenario for from tqdm.auto import tqdm

Looks like there's already an issue in tqdm

Still currently exploring different options of tqdm 😄

My Queries are:

  • Is it Ok, If we just do for jupyter notebook ?
  • For testing this, Should I go with pytest --nbval to match the output?

@V1NAY8 V1NAY8 linked a pull request Oct 26, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Solution is fleshed out and ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tqdm to pandas_to_eland() V1NAY8/eland
2 participants
@sethmlarson @V1NAY8