Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.path and url.query not used in Kibana #80

Closed
pihai opened this issue Apr 4, 2024 · 6 comments · Fixed by #81
Closed

url.path and url.query not used in Kibana #80

pihai opened this issue Apr 4, 2024 · 6 comments · Fixed by #81
Assignees
Labels
Milestone

Comments

@pihai
Copy link

pihai commented Apr 4, 2024

Hi

As it is also visible on your blog post currently the URL of an HTTP endpoint is not shown correctly.

image

I think the reason for this is that the OpenTelemetry.Instrumentation.AspNetCore library now splits the URL into url.path and url.query. See also this issue: open-telemetry/opentelemetry-specification#3181

Are we supposed to enrich every activity with url.full or how can this be fixed?

@stevejgordon stevejgordon self-assigned this Apr 4, 2024
@stevejgordon stevejgordon added this to the 1.0.0 Alpha 2 milestone Apr 4, 2024
@stevejgordon
Copy link
Contributor

Hi, @pihai.

Congratulations on being the first community issue raiser!

Thanks for submitting this issue. The proper solution is for us to update our intake process to map the updated semantic conventions for incoming (server) HTTP spans to our data model. I'll take action on that on our side.

This is a great example of the benefit this distro can provide. We should be able to include a processor to handle adding any missing attributes the current data mapping depends on so that your code doesn't have to. We'll pick that up and try to include it in a release soon.

@pihai
Copy link
Author

pihai commented Apr 4, 2024

@stevejgordon thank you so much. Now I feel guilty to raise such a minor issue as the first community feedback :D

My team has switched from Elastic APM to Open Telemetry about two years ago. It always felt a bit neglected on the Elastic side. That said, I really appreciate the effort in making the relationship between OTLP and Elastic great. Thank you.

@stevejgordon
Copy link
Contributor

@pihai No need to feel guilty. This is precisely the feedback we need to help us improve our OTel story, and it is very actionable. We appreciate you taking the time to raise it.

@stevejgordon
Copy link
Contributor

Raised elastic/apm-data#254 to capture the root cause which will be fixed so that data from any Otel SDK is treated correctly at intake.

@stevejgordon
Copy link
Contributor

@pihai This fix will go out in the next alpha quite soon. As it sounds like you're using the OTel SDK and not our distro, this won't help until the intake fixes are done, which will take a little longer. If you're willing and able, we'd love for you to try out the next alpha and see if the migration is painless (it should be simple) and if this makes the UI more useable for you.

@pihai
Copy link
Author

pihai commented Apr 8, 2024

@stevejgordon wow that was impressively quick :)

You are right, we are not using this distro yet but we strongly consider to in the future. As always things are more complicated than they should: The following issue prevents us from updating OpenTelemetry.Exporter.OpenTelemetryProtocol to the version your distro requires: open-telemetry/opentelemetry-dotnet#5083 (comment)

Once this problem is solved I can give your distro a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants