-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture span stack trace when the span ends #16
Comments
Suggestion:
|
I'm wondering whether this is actually a feature that we want to port over to the OTel-based agent. Capturing span stack traces adds overhead in both runtime and storage and I'm not sure if it is even a feature that's used a lot. |
We've included it in the list for feature parity with the existing agent, so that our customers can move to the new agent with as few differences as possible. I think we need to include it, but offering it as a feature in the Otel agent is definitely a good suggestion. We can use an alpha implementation in this agent to generate a PR for otel |
@AlexanderWert already opened a PR in semantic conventions open-telemetry/semantic-conventions#435 to add a |
Allows to make our otel agent capture span stack traces, this requires:
define if any filtering is applied on stack trace (for example to remove agent/otel internals from it)no as we plan to store it as-is on backend side, just make the UI reuse it as-is.use an ingest-pipeline to draft an apm-server solution, ideally that would allow to reuse the UI without further changes.we decided it wasn't required and could be skipped.code.stacktrace
attribute top-level apm-data#177decide if we need to implementpostponed to Config: Add support for elastic features configuration #22span_stack_trace_min_duration
configuration optionThe text was updated successfully, but these errors were encountered: