Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture span stack trace when the span ends #16

Closed
7 tasks done
SylvainJuge opened this issue Oct 10, 2023 · 4 comments
Closed
7 tasks done

Capture span stack trace when the span ends #16

SylvainJuge opened this issue Oct 10, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@SylvainJuge
Copy link
Member

SylvainJuge commented Oct 10, 2023

Allows to make our otel agent capture span stack traces, this requires:

@SylvainJuge SylvainJuge added the enhancement New feature or request label Oct 10, 2023
@SylvainJuge SylvainJuge self-assigned this Oct 10, 2023
@SylvainJuge
Copy link
Member Author

Suggestion:

  • make apm-data write the stack trace in a "raw" stack trace attribute (not in the labels as it will be by default)
  • make the UI rely on this new field when it's available.

@felixbarny
Copy link
Member

I'm wondering whether this is actually a feature that we want to port over to the OTel-based agent.

Capturing span stack traces adds overhead in both runtime and storage and I'm not sure if it is even a feature that's used a lot.
I don't have evidence either way (maybe we can get some usage stats from full story) but with the move to OTel, it could be an opportunity to re-evaluate whether we'd even want to offer that feature and whether it should be enabled by default.

@jackshirazi
Copy link
Contributor

We've included it in the list for feature parity with the existing agent, so that our customers can move to the new agent with as few differences as possible. I think we need to include it, but offering it as a feature in the Otel agent is definitely a good suggestion. We can use an alpha implementation in this agent to generate a PR for otel

@SylvainJuge
Copy link
Member Author

@AlexanderWert already opened a PR in semantic conventions open-telemetry/semantic-conventions#435 to add a code.stacktrace attribute, as it has positive feedback so far, it's likely to be the final attribute name. Having this in the semantic conventions allows us to modify the UI in Kibana and rely on labels.code.stacktrace until there is a better option for otel attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants