Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up PoC customizations in custom subproject #347

Open
JonasKunz opened this issue Aug 9, 2024 · 0 comments
Open

Clean up PoC customizations in custom subproject #347

JonasKunz opened this issue Aug 9, 2024 · 0 comments

Comments

@JonasKunz
Copy link
Contributor

The custom subproject contains some customizations which we implemented for the PoC and which are very likely not needed or might cause harm (e.g. unnecessary performance overhead).

One example is the ElasticMetricExporter class which is applied automatically and forces all metrics to be exported with delta temporality. This causes e.g. that the JVM metrics dashboards break (because they are built for the vanilla OpenTelemetry agent). Even if we later decide that delta is preferred, we should use the existing otel.exporter.otlp.metrics.temporality.preference configuration option to do that and recommend that option for the vanilla-agent aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant