Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Break out and expand IApiCallDetails #33

Open
stevejgordon opened this issue Aug 20, 2021 · 0 comments
Open

[Proposal] Break out and expand IApiCallDetails #33

stevejgordon opened this issue Aug 20, 2021 · 0 comments

Comments

@stevejgordon
Copy link
Collaborator

Today we use IApiCallDetails as a bucket of diagnostic and HTTP metadata about a request/response. While this is useful, it also causes allocations for each request and mixes functionality.

It might be useful to split this such that IApiCallDetails becomes lighter and focused on HTTP specific fields such as status code, URI, mime-type etc. These would be things we likely want to store per response. If small enough, this may also benefit from becoming a struct in the default implementation.

We could then move diagnostic fields into their own type, IApiDiagnosticDetails such that we can have an opt-out mechanism that avoids the allocation of the instance at all. Additionally, it separates the diagnostics properties from the more commonly used HTTP-related data.

We'd need to do some profiling to compare the effect of such a split as the additional field increasing the size of ITransportResponse.

@stevejgordon stevejgordon added the GA Target completion before GA 8.0.0 label Jan 25, 2022
@stevejgordon stevejgordon removed the GA Target completion before GA 8.0.0 label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant