Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash Pipeline settings builder generates invalid values for logstash pipeline queues #653

Open
robbavey opened this issue Aug 21, 2023 · 1 comment

Comments

@robbavey
Copy link
Member

Java API client version

All versions of 8.x, since at least 7.15

Java version

Any

Elasticsearch Version

All versions of 8.x, since at least 7.15

Problem description

The logstash builder has methods queueMaxBytesNumber and queueMaxBytesUnits, which serializes as

https://github.com/elastic/elasticsearch-java/blob/main/java-client/src/main/java/co/elastic/clients/elasticsearch/logstash/PipelineSettings.java#L159-L163

queue.max_bytes.number and queue.max_bytes.units, which are not valid logstash pipeline settings, and generate the following warnings when logstash starts up:

{"level":"WARN","loggerName":"logstash.configmanagement.elasticsearchsource","timeMillis":1692039467779,"thread":"Agent thread","logEvent":{"message":"Ignoring unsupported or unknown pipeline settings 'queue.max_bytes.number'"}}
{"level":"WARN","loggerName":"logstash.configmanagement.elasticsearchsource","timeMillis":1692039467779,"thread":"Agent thread","logEvent":{"message":"Ignoring unsupported or unknown pipeline settings 'queue.max_bytes.units'"}}

Additionally, the correct value of queue.max_bytes - which is a concatenated version of the two values (eg 1024mb) is not serialized, meaning that the disk queue cannot be set using this method

@yaauie
Copy link
Member

yaauie commented Aug 22, 2023

Related context in an Elasticsearch docs fix that landed in 7.17 and 8.6: elastic/elasticsearch#92651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants