Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][EuiConfirmModal] Example is broken in production #7013

Closed
cee-chen opened this issue Jul 31, 2023 · 1 comment · Fixed by #7026
Closed

[docs][EuiConfirmModal] Example is broken in production #7013

cee-chen opened this issue Jul 31, 2023 · 1 comment · Fixed by #7026
Assignees
@1Copenut
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@cee-chen
Copy link
Member

Describe the bug
See repro steps below

Environment and versions

  • EUI version: Latest prod
  • React version: 17
  • Kibana version (if applicable): N/A
  • Browser: Firefox
  • Operating System: MacOS

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/eui/#/layout/modal#loading-and-disabling-confirm-button
  2. Click "Show loading confirm modal"
  3. Sit around until eternity, the loading state never goes away

Expected behavior
Based on the code in the demo, the delete button should actually be clickable, but it never is

Minimum reproducible sandbox
N/A, issue is reproducible in EUI docs

Screenshots
Screenshot 2023-07-31 at 1 35 48 PM
@cee-chen cee-chen added bug documentation Issues or PRs that only affect documentation - will not need changelog entries ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Jul 31, 2023
@cee-chen
Copy link
Member Author

@1Copenut assigning this to you to fix as part of your support week

@1Copenut 1Copenut removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Aug 1, 2023
@1Copenut 1Copenut mentioned this issue Aug 1, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1Copenut 1Copenut

Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Fixed isLoading logic in EuiConfirmModal docs 1Copenut/eui
2 participants
@cee-chen @1Copenut