Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][EuiColorPicker] Option Toggling is rendering the addStop prop onto a DIV incorrectly #7014

Closed
1Copenut opened this issue Jul 31, 2023 · 2 comments
Labels
bug low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed

Comments

@1Copenut
Copy link
Contributor

Describe the bug
EuiColorPicker option toggle is rendering the addStop prop to a DIV incorrectly. React is warning on this item and

Environment and versions

  • EUI version: v85.0.0 (latest)
  • React version: 17
  • Kibana version (if applicable): n/a
  • Browser: Chrome
  • Operating System: MacOS

To Reproduce
Steps to reproduce the behavior:

  1. Go to CodeSandbox demo for EuiColorPicker option toggling
  2. Click on dev tools in Chromium or Firefox, then click "Console"
  3. See error:
Warning: React does not recognize the `addStop` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `addstop` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

Expected behavior
There should not be an error and the addStep prop should not be rendered into the DOM.

Minimum reproducible sandbox
No sandbox necessary. This is accessible from production docs sandbox listed in To Reproduce

Screenshots
Screen Shot 2023-07-31 at 4 41 13 PM

@1Copenut 1Copenut added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Jul 31, 2023
@1Copenut 1Copenut mentioned this issue Jul 31, 2023
15 tasks
@cee-chen cee-chen removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Jul 31, 2023
@JasonStoltz JasonStoltz added the low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed label Aug 7, 2023
@helenrekha
Copy link

helenrekha commented Aug 29, 2023

I can work on it. Could you please assign this issue to me?

@1Copenut
Copy link
Contributor Author

Hi @helenrekha. Thank you for offering to work on this issue. The EuiColorStops element that was causing the issue is scheduled for deprecation.

EUI has a list of good first issues if you're interested in contributing.

@1Copenut 1Copenut closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants