Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data grid] Single and Custom (set to 1) cell heights are incongruous #8037

Closed
ryankeairns opened this issue Sep 23, 2024 · 1 comment
Closed

Comments

@ryankeairns
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Today, when using the data grid config setting for 'Cell row height', the options for 'Single' and 'Custom = 1' result in different cell heights.
As a result, content the former does not work well in the latter. Style override with negative margins have been applied but don't fully solve the issue.

Describe the solution you'd like
Two possible solutions have surfaced:

  1. For custom, set the minimum of the range to 2 (whether by default or by prop)
  2. Adjust the behavior of data grid such that either option results in the same cell height (preferably that of 'Custom', today)

Describe alternatives you've considered
Specifically, Obs shows badges inside of cells. With that, they have used a negative margin of 2px that ensures the badge does not get clipped in 'Single' mode; however, this does not work the same in Custom mode given the aforementioned different cell heights.

You end up with things like...

Image
and...

Desired timeline
It is currently in this broken state in production today. I would defer to @tonyghiani wrt to timeline
cc:/ @timductive and @JasonStoltz given their recent involvement in prioritizing data grid work

Additional context
This is part of the One Discover initiative and applies to existing capabilities in place for Logs Explorer and Discover (via ext points).


For reference, the first image looks like this in 'Single' mode

Image

@ryankeairns
Copy link
Contributor Author

Closed by #8025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant