Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling and resolution for user/custom dashboards no longer working because of TSDB unsupported aggregations #160040

Closed
tetianakravchenko opened this issue Jun 20, 2023 · 17 comments
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Integrations Team Label for Observability Integrations team Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@tetianakravchenko
Copy link
Contributor

As a part of TSDB migration - elastic/integrations#5233, some metrics were set to type counter, this type does not support all available aggregations. OOTB dashboards were adjusted accordingly, but for custom dashboards should be provided more helpful error messages.

Example:
For fields with the type: counter, avg aggregation is not supported (as other aggregation, except max and last_value)
Capture d’écran 2023-06-19 à 19 11 41

Error message is not really descriptive, would be helpful to add clarification, that supported aggregations for this type are max or last_value

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 20, 2023
@mlunadia
Copy link

There are two milestones we need to guide users to achieve:
1. Error awareness: Better error handling for users who have dashboards with TSDB unsupported aggs
2. Error resolution: Surfacing options to those aggregations (where available)
eg. users could be directed in the error message to a document explaining in detail and potential options they can use to replace unsupported aggregations.

@mlunadia mlunadia changed the title Error handling for TSDB unsupported aggs Error handling and resolution (where available) for user dashboard no longer working because of TSDB unsupported aggs Jun 20, 2023
@mlunadia mlunadia changed the title Error handling and resolution (where available) for user dashboard no longer working because of TSDB unsupported aggs Error handling and resolution for user dashboard no longer working because of TSDB unsupported aggs Jun 20, 2023
@mlunadia mlunadia changed the title Error handling and resolution for user dashboard no longer working because of TSDB unsupported aggs Error handling and resolution for user dashboards no longer working because of TSDB unsupported aggs Jun 20, 2023
@lalit-satapathy
Copy link

Earlier issue for this here and the scenario reproducing the same.

@mbondyra mbondyra added the Team:Integrations Team Label for Observability Integrations team label Jun 22, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 22, 2023
@dej611 dej611 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@lalit-satapathy
Copy link

lalit-satapathy commented Jul 4, 2023

Couple of recent offline threads where custom dashboards got broken, because a field is now a TSDB counter. Need a compressive document to assist the user migration process for the custom dashboards.

  1. From @lucabelluccini : k8 package

reported a customer complaining why they cannot perform an avg aggregation anymore on the field kubernetes.pod.network.rx.bytes. They get:

Field [kubernetes.pod.network.rx.bytes] of type [long] is not supported for aggregation [avg]

This is associated with the K8s switch to TSDB GA.

  1. From @Danouchka : System package
    Hello, Since 8.8.1, I have the following error
    Field [XXX] of type [long] is not supported for aggregation [avg]. Is it a bug ?

Capture d’écran 2023-06-19 à 19 11 41

CC: @mlunadia @giladgal

@timductive timductive added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Jul 6, 2023
@timductive
Copy link
Member

@martijnvg will work on adding documentation and work with docs team on where it lives.
@dej611 can update the error message and link to the doc when its ready.

@lalit-satapathy
Copy link

Link to ES issue: "Enable all aggregations on counter fields"- elastic/elasticsearch#97882

@lalit-satapathy lalit-satapathy changed the title Error handling and resolution for user dashboards no longer working because of TSDB unsupported aggs Error handling and resolution for user/custom dashboards no longer working because of TSDB unsupported aggregations Aug 3, 2023
@lalit-satapathy
Copy link

Capturing below a brief summary of the behaviour of custom dashboards in Kibana while using un-supported counter aggregations. This is fixed as part of elastic/elasticsearch#97974

  • Fixed 8.9.1 onwards
  • Developing new dashboards with un-supported counter aggregations is still an error in Kibana.
  • Upgrading stack, while using a custom dashboard with un-supported counter aggregations, is now supported.
    • Is there any warning in this case?

@dej611 @salvatore-campagna @martijnvg, Please update if this is accurate.

@dej611
Copy link
Contributor

dej611 commented Aug 29, 2023

Developing new dashboards with un-supported counter aggregations is still an error in Kibana.

A user should not be able to create a visualization with un-supported counter aggregations within Lens, the editor should prevent to build and save such configuration. If some user manually builds the visualization via manually write the SO, then the other "relaxed" check will kick in.

Upgrading stack, while using a custom dashboard with un-supported counter aggregations, is now supported.
Is there any warning in this case?

Yes, there's a warning showing up in this case but the visualization will be rendered.

image

@lalit-satapathy
Copy link

Thanks @dej611 for the clarifications.

@harnish-elastic, Please check with one custom dashboard for a TSDB enabled package, to verify that both the behaviours captured above are working.

@harnish-elastic
Copy link

harnish-elastic commented Aug 31, 2023

@lalit-satapathy and @dej611, I have performed the above-mentioned scenarios on the cloud elastic. However, I am not able to get the warning in 8.9.1 kibana! Please refer to the below steps that I have performed!

Summary:

  • Create the deployment of the Kibana version 8.4.0 (< 8.7.0) from cloud.elastic.co
  • Start the data collection for the integration packages(Apache and ActiveMQ) via Elastic-Agent
  • Create the Custom dashboard including the counter metric_type fields using un-supported aggregation(Average/Sum)
  • Go to the deployment and upgrade the current stack to 8.9.1
  • Upgrade the integration policy and package version to the latest(including TSDB enablement) or delete the existing policy, add the new policy, and restart the data collection!
  • Observe the behavior of the Custom dashboard

Output:

  • Not able to see any warnings on the visualization
  • I am able to create a fresh dashboard with the counter metric_type fields using un-supported aggregation(Average/Sum) in 8.9.1 for the same integration package in the stack without any warning/error.

Screenshots:

image
image
image

Let me know if there is anything else I can perform to re-produce the warning!

@dej611
Copy link
Contributor

dej611 commented Aug 31, 2023

The backport had some bumps and it seems that it didn't make it to 8.9.1 but rather in 8.9.2: #163515

@lalit-satapathy
Copy link

@harnish-elastic, Please confirm that it is working 8.9.2

@harnish-elastic
Copy link

@harnish-elastic, Please confirm that it is working 8.9.2

@lalit-satapathy I have performed the same steps mentioned in this comment. However, I still cannot see the warning message in the visualizations. Let me know if there is anything else I can perform to re-produce the warning!

@lalit-satapathy
Copy link

What about 8.10?

@harnish-elastic
Copy link

harnish-elastic commented Sep 11, 2023

What about 8.10?

The current latest deployment in the elastic cloud is 8.9.2! So I cannot perform this scenario. Let me know if there are other ways to test on 8.10.0
image

@stratoula
Copy link
Contributor

Hey, can we close this issue?

@markov00
Copy link
Member

I'm going to close this issue, please reopen it if the problem persist in 8.14 or higher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Integrations Team Label for Observability Integrations team Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

10 participants