Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Implement mechanism for managing flyouts #194239

Open
davismcphee opened this issue Sep 27, 2024 · 2 comments
Open

[Discover] Implement mechanism for managing flyouts #194239

davismcphee opened this issue Sep 27, 2024 · 2 comments
Labels
Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture

Comments

@davismcphee
Copy link
Contributor

Discover uses several flyouts (e.g. doc viewer, ES|QL help, Lens editor), and they can overlap if not properly managed, for example when two push flyouts are opened at once:

We implemented a quick fix to address this problem in #193865, but we should figure out a more robust way to manage flyouts longer term, which can also be used by Discover extensions that show flyouts (e.g. cell renderer with a link that opens a flyout). One idea would be to create something like a central "flyout manager" that's responsible for ensuring only one flyout is opened at once in Discover.
@davismcphee davismcphee added Feature:Discover Discover Application Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture labels Sep 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee mentioned this issue Sep 27, 2024
Merged
2 tasks
@kertal
Copy link
Member

kertal commented Sep 27, 2024 •
edited
Loading

Linking elastic/eui#8042, because ideally we wouldn't need to deal with this on plugin level , and also related: elastic/eui#7443

@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kertal @elasticmachine @davismcphee