[FTR][Ownership] Fixup test_serverless entries #195609
Conversation
wayneseymour
added
release_note:skip
|
@azasypkin Further, should they not be assigned to kibana security? |
Yeah, none of the test paths mentioned in this PR should be owned by the AppEx Platform Security team. Since these are under |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
wayneseymour
requested review from
joemcelroy
and removed request for
joemcelroy
.github/CODEOWNERS
Outdated
| @@ -1297,6 +1298,7 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai | |||
| #CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-presentation | |||
|
|
|||
| # Machine Learning | |||
| /x-pack/test_serverless/functional/test_suites/security/ml @elastic/ml-ui | |||
There was a problem hiding this comment.
Is this needed? We already have /x-pack/test_serverless/**/test_suites/**/ml/ @elastic/ml-ui below.
There was a problem hiding this comment.
I ran the following on the main branch:
$ node scripts/get_owners_for_file.js --file x-pack/test_serverless/functional/test_suites/security/ml
ERROR Ownership of file [x-pack/test_serverless/functional/test_suites/security/ml] is UNKNOWN
Looks like we need an assignment Pete.
There was a problem hiding this comment.
I don't know why the wildcard ** aren't working. There are a lot of other uses of the wildcard syntax in this file. Do any of them work as intended?
If the ** isn't working, then you'd also have to add entries for
/x-pack/test_serverless/functional/test_suites/observability
/x-pack/test_serverless/functional/test_suites/search
There was a problem hiding this comment.
Looks like you correct:
node scripts/get_owners_for_file.js --file x-pack/test_serverless/functional/test_suites/observability
ERROR Ownership of file [x-pack/test_serverless/functional/test_suites/observability] is UNKNOWN
As I'm responsible for assigning all of them, and ensuring this script returns zero missing owners as apart of this effort, this will most definitely be followed up in a PR soon.
It'll all be fixed up sooner than later.
There was a problem hiding this comment.
Furthermore, a follow-on project is coming to co-locate tests with what they test (plugins, packages, etc).
So the codeowners file will get an additional cleanup then as well.
There was a problem hiding this comment.
There was a problem hiding this comment.
With the investigations done as part of #197805, we know that /x-pack/test_serverless/functional/test_suites/security/ml is actually covered by the /x-pack/test_serverless/**/test_suites/**/ml/ @elastic/ml-ui entry and the updated check script will reflect that once that PR is merged. So this additional entry can be removed.
There was a problem hiding this comment.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
|
|
@elasticmachine merge upstream |
Summary
Changing lines from security-solution to other team, per request.
Contributes to: #194815
Addresses: https://github.com/elastic/kibana/pull/194819/files/d4eb7a8b397e15357790ba32a0266e724d2b775b#r1792990254