[Entity Analytics] [Entity Store] Show errors on entity store enablement #198263
Conversation
tiansivive
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
There was a problem hiding this comment.
Hey @tiansivive ! Overall looks good. Focussed review on SO parts and left some qs.
| }, | ||
| { | ||
| type: 'data_backfill', | ||
| backfillFn: (document) => { |
There was a problem hiding this comment.
If you are adding a new default field to the schema that is optional we don't need to run this backfill operation, leaving it undefined should be fine. Or does null mean something specific in this case?
There was a problem hiding this comment.
no, it was meant to clearly state there was no value as its optional. I wasn't sure whether just leaving it undefined would work. I'll update
| error: { | ||
| type: 'object', | ||
| }, |
There was a problem hiding this comment.
Are we searching over this value? If not then we don't need to include it in mappings.
There was a problem hiding this comment.
so I dont need to add a migration for it? I can just "silently" add it to the saved object?
There was a problem hiding this comment.
I ended up removing the migration, seems like that is the correct way to do this since we never want to search on errors. Please do let me know if there are other concerns wrt the SO @jloleysens
...ity_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
Outdated
Show resolved
Hide resolved
...ity_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
Outdated
Show resolved
Hide resolved
...ity_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
Outdated
Show resolved
Hide resolved
...ugins/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
Outdated
Show resolved
Hide resolved
...security_solution/server/lib/entity_analytics/entity_store/saved_object/engine_descriptor.ts
Outdated
Show resolved
Hide resolved
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
tiansivive
force-pushed
the
ea-entity-store-10900
branch
from
b5a88c1
to
29b6fea
Compare
… src/core/server/integration_tests/ci_checks'
Summary
This PR adds user feedback for errors that happen when enabling the entity store.
Any errors during the async setup of store resources will show up as toasts, whist initial INIT request failures will appear as an error callout.