Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 370: Useless regular-expression character escape #198264

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kfirpeled
Copy link
Contributor

Fixes https://github.com/elastic/kibana/security/code-scanning/370

To fix the problem, we need to remove the unnecessary escape sequence \- from the regular expression on line 32. This will not change the functionality of the code but will make the regular expression clearer and more maintainable.

  • In general terms, we need to ensure that only necessary escape sequences are used in regular expressions.
  • Specifically, we will update the regular expression on line 32 to remove the unnecessary escape sequence.
  • The change will be made in the file x-pack/plugins/session_view/public/methods/index.tsx.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

… escape

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 30, 2024
@Omolola-Akinleye Omolola-Akinleye added the ci:cloud-deploy Create or update a Cloud deployment label Oct 30, 2024
@Omolola-Akinleye
Copy link
Contributor

/ci

@Omolola-Akinleye Omolola-Akinleye marked this pull request as ready for review October 30, 2024 20:16
@Omolola-Akinleye Omolola-Akinleye requested a review from a team as a code owner October 30, 2024 20:16
@Omolola-Akinleye Omolola-Akinleye marked this pull request as draft October 30, 2024 20:34
@Omolola-Akinleye Omolola-Akinleye marked this pull request as ready for review October 30, 2024 21:28
@Omolola-Akinleye Omolola-Akinleye marked this pull request as draft October 30, 2024 21:54
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@Omolola-Akinleye
Copy link
Contributor

@kfirpeled Session Viewer is working fine!
image

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants