-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Revert security_solution_common
package which is unnecessary
#198294
base: main
Are you sure you want to change the base?
[Security Solution] Revert security_solution_common
package which is unnecessary
#198294
Conversation
/ci |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defend Workflows Code changes LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few very minor comments
x-pack/plugins/security_solution/public/flyout/document_details/left/components/tour.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/document_details/right/components/tour.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/shared/components/expandable_panel.test.tsx
Outdated
Show resolved
Hide resolved
⏳ Build in-progress, with failures
Failed CI StepsMetrics [docs]
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-only review, Data Discovery changes LGTM 👍 Just to confirm, are you removing security-solution-common
because you're no longer intending to extract the components and instead use discover_shared
for IoC?
Thanks @davismcphee . To answer your question, Yes, exactly. In current state |
Summary
This PR reverts #189633.
Background
PR : #189633 had created a package
security_solution_common
so that security components can be easily used in Discover plugins.But because of recent direction change, I have decided to revert that change which mainly moved
flyout
code to thesecurity_solution_common
package.Most of the changes that you will see will be path changes replacing
security_solution_common
.TL;DR
security_solution_common
is being removed as the reason it was created does not exists any more.