Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Update default Bedrock api url (#176090) #176206

Closed

Conversation

shahzad31
Copy link
Contributor

…ils page (#175513)

Resolves #174075,
#155691

  • Using same chart in alert details page as in rule flyout for preview
  • Group by info is applied as filter on chart data
  • Added annotations
  • For active alerts, added point annotation with alert start time and
    range annotation with range from alert start time till current time
    • For recovered alerts, added range annotation for alert duration

Active alert

Screenshot 2024-01-26 at 15 05 26

Screenshot 2024-01-26 at 15 09 44

Recovered alert

Screenshot 2024-01-26 at 14 53 08


Co-authored-by: kibanamachine [email protected]## Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

stephmilovic and others added 16 commits February 2, 2024 10:43
## Summary

Fixes filter disappearing on reload !!

Filters when applied were disappearing on reload.
…istory (elastic#175810)

## Summary

Adds agent type filter values to the `Type` filter on actions history.
So in addition to filtering by action type one can also filter with
agent types.

- With the feature flag enabled, the filter name changes to `Types` as
it now holds Action and Agent types filter options. A new URL param
called `agentTypes` is added when agent type options are selected. The
existing `types` URL param works the way it does now.
- Without the feature flag enabled the filter behaves and looks the way
it does currently.

**with feature flag `responseActionsSentinelOneV1Enabled` on**
<img width="2056" alt="Screenshot 2024-02-01 at 11 27 52 AM"
src="https://github.com/elastic/kibana/assets/1849116/83e17587-5e49-481e-9a85-cbb3642873b7">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
## Summary
Still trying to fix the daily coverage job, that I managed to break
while setting up another new target for the uploaded artifacts.

This time, fixing (as seen at: [this
build](https://buildkite.com/elastic/kibana-code-coverage-main/builds/1291#018d6830-f9cb-4034-9d23-1686a6218c0f))
```
BadRequestException: 400 Cannot insert legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access
```

Supposed fix is already applied:
elastic/kibana-operations#55
Creates a new registry for `React Embeddables` and allows the Dashboard to render them.
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This pipeline is a no-op for the moment, but will enable testing in
branches.
## Summary

This PR removes unused kbn url state package. It was only used in the
flyout and is now replaced with a shared utility, used by several other
modules.

---------

Co-authored-by: kibanamachine <[email protected]>
…ils page (elastic#175513)

Resolves elastic#174075,
elastic#155691

- Using same chart in alert details page as in rule flyout for preview
- Group by info is applied as filter on chart data
- Added annotations
- For active alerts, added point annotation with alert start time and
range annotation with range from alert start time till current time
  - For recovered alerts, added range annotation for alert duration

### Active alert
<img width="1257" alt="Screenshot 2024-01-26 at 15 05 26"
src="https://github.com/elastic/kibana/assets/69037875/d548b529-7811-4e3e-996d-aa4d259327b9">

<img width="1265" alt="Screenshot 2024-01-26 at 15 09 44"
src="https://github.com/elastic/kibana/assets/69037875/a01d0cdf-5254-484d-91b3-c45a846790a9">

### Recovered alert
<img width="1250" alt="Screenshot 2024-01-26 at 14 53 08"
src="https://github.com/elastic/kibana/assets/69037875/521a69a2-6a4a-4b9e-a886-3477c92d63ac">

---------

Co-authored-by: kibanamachine <[email protected]>
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.