Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new o11y nav hierarchy for serverless #193510

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement new o11y nav hierarchy for serverless #193510

wants to merge 8 commits into from
+217 −118

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Sep 20, 2024 •
edited
Loading

Fixes #192804

This PR updates the nav hierarchy on serverless and changes the accordion to panelOpener. The menu items have been updated according to the Figma file. Here's a Video of how nav hierarchy looks like on serverless with the new changes:

Screen.Recording.2024-10-07.at.13.39.30.mov

What was changed

  • AI & ML menu is removed and split into
    • AI Assistant
    • Machine learning
  • Applications now opens a panelOpener instead of an accordion
    • Service Inventory was renamed to Service inventory to meet the use of sentence-case requirement
    • Synthetics was moved to a new section
  • Infrastructure
    • Infrastructure Inventory was renamed to Infrastructure inventory to match the sentence-case requirement
  • Machine learning: this menu was not present at all on serverless

Notes for the Reviewer

  • Stack Management on security and search don't use any panelOpener, they use a landing page instead. In order to be consistent with the rest solutions, I kept Stack Management as is.
  • Machine Learning menu item was not present at all on serverless. I need a confirmation, that it is fine to bring it in as it is from stateful cc @vinaychandrasekhar

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mgiota
Copy link
Contributor Author

mgiota commented Oct 7, 2024

@elasticmachine merge upstream

@mgiota mgiota marked this pull request as ready for review October 7, 2024 11:18
@mgiota mgiota requested a review from a team as a code owner October 7, 2024 11:18
@mgiota mgiota self-assigned this Oct 7, 2024
@mgiota mgiota added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-management Observability Management User Experience Team labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@mgiota mgiota added the v9.0.0 label Oct 7, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 7, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 7, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

@mgiota mgiota force-pushed the change_navigation_serverless branch from 5531ade to 1edc895 Compare October 7, 2024 19:21
@mgiota
Copy link
Contributor Author

mgiota commented Oct 30, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2024 •
edited
Loading

💔 Build Failed

  • Buildkite Build
  • Commit: e1f730d
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193510-e1f730daeb2a

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / GenAI - Knowledge Base Entries APIs @ess Basic Security AI Assistant Knowledge Base Entries "before all" hook in "@ess Basic Security AI Assistant Knowledge Base Entries"
  • [job] [logs] FTR Configs #1 / GenAI - Knowledge Base Entries APIs @ess Basic Security AI Assistant Knowledge Base Entries "before all" hook in "@ess Basic Security AI Assistant Knowledge Base Entries"
  • [job] [logs] FTR Configs #33 / serverless observability UI - feature flags Observability Infra Infra Side Navigation when Hosts settings is on "before all" hook for "shows the 'Hosts' nav item"
  • [job] [logs] FTR Configs #33 / serverless observability UI - feature flags Observability Infra Infra Side Navigation when Hosts settings is on "before all" hook for "shows the 'Hosts' nav item"
  • [job] [logs] FTR Configs #79 / serverless observability UI navigation navigate observability sidenav & breadcrumbs
  • [job] [logs] FTR Configs #79 / serverless observability UI navigation navigate observability sidenav & breadcrumbs

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 27.2KB 28.9KB +1.7KB

History

cc @mgiota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgiota mgiota

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability serverless nav] Change nav hierarchy using panelOpener
4 participants
@mgiota @obltmachine @elasticmachine @kibana-ci