Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Support TLS 1.3 #10494

Closed
38 of 40 tasks
jsvd opened this issue Feb 26, 2019 · 5 comments
Closed
38 of 40 tasks

[Meta] Support TLS 1.3 #10494

jsvd opened this issue Feb 26, 2019 · 5 comments

Comments

@jsvd
Copy link
Member

jsvd commented Feb 26, 2019

TLS v1.3 is available since Java 8u262-b10 (AdoptOpenJDK) or 8u261-b12 in the Oracle build.
https://java.com/en/jre-jdk-cryptoroadmap.html

Logstash 7.15/16 ships with Java 11 and 8.0 will even drop support for Java 8 -> TLS v1.3 could be assumed available.

This issue intends to track all the work towards being confident that Logstash supports TLS v1.3.


Core


Dependencies

  • confirm Manticore (Apache HttpClient 4.x) works as expected against TLSv1.3
  • JRuby-OpenSSL lacks support for TLSv1.3 (initial support available in 0.12.1)
    scope unknown -> need to review Ruby OpenSSL + C-OpenSSL changes
  • extra JOSSL support to be able to select Java cipher names for an SSL context
    to allow easy cipher_suites => ... support for low level plugins such as the tcp input (requested feature)
  • Puma does not support TLSv1.3 using it's MiniSSL JRuby implementation
    scope should be relatively simple

Plugins

@karenzone
Copy link
Contributor

Related: #12024

@roaksoax roaksoax added hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" shortlist labels Nov 17, 2021
@roaksoax roaksoax added the meta label Nov 30, 2021
@roaksoax roaksoax changed the title Support TLS 1.3 [Meta] Support TLS 1.3 Nov 30, 2021
@kares kares removed the hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" label Mar 3, 2022
@endorama
Copy link
Member

endorama commented Mar 9, 2022

Hello, looking at the status of this issue it seems TLS 1.3 is still not supported by Logstash, but I found an old PR (June 2020) where TLS 1.3 is mentioned.

Could you please confirm if it's supported or not? I come here from the Beats input documentation page that says max TLS version supported is 1.2, but I'm not sure is correct.

Thanks!

@tsaarni
Copy link

tsaarni commented Mar 10, 2022

I can help with beats input.

@kares
Copy link
Contributor

kares commented Mar 14, 2022

@endorama the story is in general that TLS 1.3 support depends plugin by plugin and also the JDK used (in case of old LS versions or running on older Java 8 versions).

for Beats, unfortunately, the tls_max_version parameter is hard-coded to 1.2 thus it does not adapt to enabling 1.3 despite the underlying Java SSL engine having the support (likely relates to the cipher_suites parameter which also needs revisiting). part of this meta issue we plan to look into getting Beats ready for TLS 1.3 - work is done plugin by plugin, hopefully Beats will be completed within the next few weeks.

@tsaarni thanks for the effort, whatever progress you're able to do I can built upon, what might server as an example to some extent is what we did in TCP input ... as to how much existing Beats option we'll deprecate in favor of a naming similar to the TCP input added options is undecided at this point.

@roaksoax
Copy link
Contributor

Closing this issue as Logstash now supports TLS 1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants