Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise on non-200? #1

Open
jrochkind opened this issue Mar 4, 2013 · 0 comments
Open

raise on non-200? #1

jrochkind opened this issue Mar 4, 2013 · 0 comments

Comments

@jrochkind
Copy link

The response object has a #responsecode, implying that you might find a code other than 200 there.

But if the API returns a 5xx (say, because I didn't give it the right secret key), I don't get back a response with a 5xx responsecode... I get an exception raised.

Would it make more sense to make this not raise but return a non-200 response code? Or to make it a call option? Or to at least document in what cases one should expect an exception (of what class) to be raised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant