feat(appx): Update identityName for windows 10 #8206
Conversation
ifurther
commented
May 7, 2024
•
ifurther
commented
- Split the applicationid and identityname detect function
- Add auto remove the identityname in Microsoft store has some number in first
🦋 Changeset detectedLatest commit: 29b90b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mmaietta I updated the test file. |
|
Looks like there's some compilation issues now: |
|
@mmaietta I removed it |
|
@mmaietta Sorry I find the error which is for loop logical. |
|
@mmaietta Sorry I fixed the if loop |
ifurther
force-pushed
the
appx
branch
2 times, most recently
from
c9b0745
to
93e6da5
Compare
|
@mmaietta I check the applicationid and identityname rule and update it. |
|
@mmaietta I updated the replace and find number detection |
|
@mmaietta I found the error and updated it |
|
@mmaietta I found the error and updated it |
|
Looking good! Left a minor comment about a more informative error message, other than that, this will be good to go 🙂 |
|
Thank you |
