Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.readShortcutLink crashes when parsing Slack shortcut #45166

Open
3 tasks done
dlon opened this issue Jan 9, 2025 · 1 comment · May be fixed by #45195
Open
3 tasks done

shell.readShortcutLink crashes when parsing Slack shortcut #45166

dlon opened this issue Jan 9, 2025 · 1 comment · May be fixed by #45195
Labels
33-x-y bug 🪲 component/shell has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows

Comments

@dlon
Copy link

dlon commented Jan 9, 2025

Preflight Checklist

Electron Version

33.3.1

What operating system(s) are you using?

Windows

Operating System Version

Windows 11 version 26100

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

Shortcut should be parsed/read correctly, and we should be able to handle the error if this fails.

Actual Behavior

An exception is thrown:

[1212:0109/171356.871:ERROR:crashpad_client_win.cc(868)] not connected

Testcase Gist URL

https://gist.github.com/dlon/f580673b27ba00d1bedfa25d2f2208c1

Additional Information

This seems related to #44752, but it affects other shortcuts.

Here is a partial backtrace:

00 00000072`1e5fc3a0 00007ff7`f38192e9     electron!base::win::ResolveShortcutProperties+0xaaa [C:\projects\src\base\win\shortcut.cc @ 345] 
01 00000072`1e5fc6e0 00007ff7`f36ecd16     electron!`anonymous namespace'::ReadShortcutLink+0xd9 [C:\projects\src\electron\shell\common\api\electron_api_shell.cc @ 154] 

I've reproduced the above on v33.3.1, as well as the latest beta.

@dlon dlon added the bug 🪲 label Jan 9, 2025
@electron-issue-triage electron-issue-triage bot added 33-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows labels Jan 9, 2025
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 33-x-y Jan 9, 2025
@dlon
Copy link
Author

dlon commented Jan 10, 2025

I've found an issue and fix. I'll try to provide a patch when I have time.

@dlon dlon linked a pull request Jan 14, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
33-x-y bug 🪲 component/shell has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows
Projects
Status: 👀 Unsorted Items
Development

Successfully merging a pull request may close this issue.

2 participants