Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Render poll start events in the timeline #1830

Closed
7 tasks done
Tracked by #1526
Johennes opened this issue Jul 10, 2023 · 2 comments
Closed
7 tasks done
Tracked by #1526

[Story] Render poll start events in the timeline #1830

Johennes opened this issue Jul 10, 2023 · 2 comments
Assignees
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@Johennes
Copy link
Contributor

Johennes commented Jul 10, 2023

Description

  • As a user
  • I want to see when polls are started in the timeline
  • so that I can follow (and later vote on) them
  • There will be no limit to the length of a poll option, we won't truncate the text on screen. We'll simply show all the text we have.

Size estimate

M

Dependencies

Acceptance criteria

  • Poll start events are rendered in the timeline (when poll is created from another session/app)
  • If user has voted on the poll from another platform, they can see their own votes
  • If a user changes their vote on another platform, the vote updates on EX in real time
  • If the "show votes" switch is enabled, the results can be seen before and after voting (and when poll closes)
  • If the "show votes" switch is disabled, the results cannot be seen before or after voting as long as the poll is open (can be seen once poll closes)
  • Poll end events are not rendered in the timeline1
  • Poll votes are not rendered in the timeline
  • When the poll has ended, the start event is updated to show closed state (radio buttons are no longer visible and total is shown in all cases, user's own vote is highlighted in green/bold)
  • Poll in timeline is accessible to native OS screen readers
  • Poll matches designs for dark and light themes - dark theme designs are not provided, use compound

Testing:
Mix of unit testing and manual testing in Kiwi

Out of scope

  • Creating a poll from EX
  • Editing a poll
  • Voting on a poll
  • Vote withdrawal

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Subtasks

External Dependencies

Figma designs

Open Questions

What to do when there are UTDs in any of the events needed for aggregation? Should we still show partial (i.e. incorrect) results or should we not show any result? Should we also surface a human readable UTD warning?

iOS

Preview Give feedback
  1. alfogrillo
  2. alfogrillo

Other

Preview Give feedback
No tasks being tracked yet.

Footnotes

  1. This matches other platforms and helps mitigate the impact of not using the relations API within the timeline to get accurate poll results in the initial version

@Johennes Johennes changed the title [Story] Render poll start and end events in the timeline [Story] Render poll start events in the timeline Jul 18, 2023
@sempruijs
Copy link

I think poll should be treated in the following way:

[{title}]
[{name_option_1}, {is_selected}, {percentage}]
[{name_option_2}, {is_selected}, {percentage}]
[{amount_of_votes_casted}]

each [] set is 1 element that you can hear.

I use screenreader every day and I believe that this is a good implementation for talkback as wel as VoiceOver

@julioromano
Copy link

I think poll should be treated in the following way:

[{title}] [{name_option_1}, {is_selected}, {percentage}] [{name_option_2}, {is_selected}, {percentage}] [{amount_of_votes_casted}]

each [] set is 1 element that you can hear.

I use screenreader every day and I believe that this is a good implementation for talkback as wel as VoiceOver

@kittykat @sempruijs this should improve a bit the talkback behavior on polls.
It should be out in tomorrow's nightly. Please let me know what you think about it.

@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

7 participants