Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Push notifications for polls #2071

Closed
6 tasks done
Tracked by #1526
alfogrillo opened this issue Sep 22, 2023 · 1 comment
Closed
6 tasks done
Tracked by #1526

[Story] Push notifications for polls #2071

alfogrillo opened this issue Sep 22, 2023 · 1 comment
Assignees

Comments

@alfogrillo
Copy link

alfogrillo commented Sep 22, 2023

Description

  • As a user
  • I want to receive notification for polls
  • So that I'm aware of new started polls

Acceptance criteria

  • The user receives a push notification for each "poll started" event in group and direct rooms
    • The above happens only if the Group chat / Direct chat notification settings are set to All messages
    • Notification message: Poll: {poll_question}
  • Notifications should work both for encrypted and plain rooms
    • The rust sdk should apply already the push rules automatically for encrypted rooms
  • Polls push rules should be in sync with the ones of normal messages (see the table below)
  • Element X should align poll rules with the one of messages whenever a message push rule changes (see the table below).
  • In case of inconstancies the user should see this screen.
    • A tap on the "Continue" button should sync all the rules. Poll rules should copy the messages one (see the table below)
Poll rules Align to
.m.rule.poll_start_one_to_one
.org.matrix.msc3930.rule.poll_start_one_to_one
.m.rule.room_one_to_one
.m.rule.poll_start
.org.matrix.msc3930.m.rule.poll_start
.m.rule.message

Size estimate

None

Dependencies

  • None

Preconditions

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Out of scope

  • TBD

Open questions

  • Can we ignore "poll end" events? (we don't show them in the timeline, and we couldn't jump to the start event when clicking on the notification, so does it make sense to display notifications for them?)
    • A: "poll end" events will be addressed together with poll history later
  • Push rules sync between poll rules and "regular" rules: do we really have to expose this to the user as it was done in legacy clients? Ideally this should be user transparent.
    • A: EX already has a screen to warn the user about "inconsistencies" on push rules (without mentioning any particular rule). polls rules should be aligned using the same screen in case of problems.

Subtasks

Android

Preview Give feedback
  1. julioromano

iOS

Preview Give feedback
  1. alfogrillo
  2. alfogrillo
@julioromano
Copy link

julioromano commented Sep 25, 2023

Can we ignore "poll end" events?

@VolkerJunginger wanted to have a notification on poll end. This means we can't ignore them. Though, with the current state of the SDK, I don't think we can scroll the timeline all the way to the start event when clicking on the "end poll" notification. What d'you think @alfogrillo ?

We definitely can manage to get push notifications for "poll ended" events.
This would require the sync of "poll end" push rules with the ones of normal messages (4 more lines in the table above).
But like you said we don't have a working "go to" navigation in the timeline atm.
To be fair I think this a general problem with push notifications and links and isn't limited to "poll end" events.

@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants