Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect or correct security phrase for setting up recovery silently fails #29099

Open
tuxayo opened this issue Jan 26, 2025 · 0 comments
Open
Labels
A-E2EE A-Error-Message O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@tuxayo
Copy link
Contributor

tuxayo commented Jan 26, 2025

Steps to reproduce

  1. A prompt suggests me to "set up recovery". When I put my security Phrase and hit "continue" it just closes with the message suggesting "set up recovery" still there.
  2. If I use my security key, the UI tells me it's correct but when I hit "continue", the same happens as above.
  3. In the JS console I see among other things:
    Olm device has private keys and they are saved in secret storage; doing nothing
    Not saving backup key to secret storage: no backup key
  4. When I put a wrong security phrase, I get in the console "accessSecretStorage: error during operation Error: Error decrypting secret m.cross_signing.master: bad MAC"
  5. With the UI just closing the modal and the prompt "Set up recovery" still there.

That's when I found #13180

Outcome

What did you expect?

Happy path working.
Unhappy path not having a JS error and instead having appropriate feedback in the UI.

Operating system

EndeavourOS (Arch Linux based)

Browser information

Firefox 134.0.2

URL for webapp

https://app.element.io

Application version

No response

Homeserver

No response

Will you send logs?

Yes

@dosubot dosubot bot added A-E2EE A-Error-Message O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-Error-Message O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

1 participant