Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Picture-in-Picture "mask" the window instead of drawing a region #658

Open
cassidyjames opened this issue Dec 12, 2019 · 2 comments · May be fixed by #2143
Open

Make Picture-in-Picture "mask" the window instead of drawing a region #658

cassidyjames opened this issue Dec 12, 2019 · 2 comments · May be fixed by #2143
Assignees
@JoseExposito
Labels
Priority: Wishlist An enhancement or new feature Status: Confirmed Verified by someone other than the reporter

Comments

@cassidyjames
Copy link
Contributor

Right now PiP works by drawing a rectangular region on the window, which has some issues:

  • You only get one shot; if you mess up, you have to close PiP and start over
  • The original window sticks around, meaning you have two copies of the content
  • It's unclear what you're supposed to do when you hit the shortcut

Instead, we should switch to a corner grabber design that masks/clips the window down to the chosen PiP area, with an explicit "confirm" button to complete the area selection. Here is a sketch I did a while back:

MVIMG_20191211_220137

And here is a rough motion mockup on YouTube.
@cassidyjames cassidyjames added Priority: Wishlist An enhancement or new feature Needs Design Waiting for input from the UX team labels Dec 12, 2019
@worldofpeace
Copy link
Contributor

Would be fab for #646.

@cassidyjames cassidyjames added Status: Confirmed Verified by someone other than the reporter and removed Needs Design Waiting for input from the UX team labels Dec 17, 2019
@cassidyjames cassidyjames pinned this issue Dec 17, 2019
@cassidyjames cassidyjames mentioned this issue Sep 28, 2020
Open
@hanaral
Copy link

hanaral commented Dec 26, 2020

Gtk4 seems to have good builtin media player support, maybe something could be done with that?

@JoseExposito JoseExposito mentioned this issue Aug 5, 2021
Closed
12 tasks
@JoseExposito JoseExposito self-assigned this Aug 5, 2021
@danirabbit danirabbit unpinned this issue Mar 31, 2023
This was referenced Dec 3, 2024
Closed
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoseExposito JoseExposito

Labels
Priority: Wishlist An enhancement or new feature Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PiP: Mask window elementary/gala
PiP: Mask window elementary/gala
4 participants
@cassidyjames @JoseExposito @worldofpeace @hanaral