Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer support for non-512-byte sector sizes #448

Open
vjr opened this issue Sep 12, 2020 · 2 comments · May be fixed by #621
Open

Installer support for non-512-byte sector sizes #448

vjr opened this issue Sep 12, 2020 · 2 comments · May be fixed by #621
Labels
Priority: Medium Should be addressed when time allows

Comments

@vjr
Copy link
Member

vjr commented Sep 12, 2020

See pop-os/distinst#181

Noticed this while working on #447
@vjr
Copy link
Member Author

vjr commented Sep 12, 2020

Looks like installer code already handles/uses the distinst disk get_sector_size () value, except for the https://github.com/elementary/installer/blob/master/src/Objects/Mount.vala class.

This may only be relevant for the EFI ESP partition size check, in the (rare?) occasion the sector size is not 512 bytes, so this issue is probably low priority.

@vjr vjr mentioned this issue Sep 12, 2020
Closed
@dr-Styki
Copy link

+1 With 4k sector size, a 256GB SSD is shown as a 32GB SSD
With 4k sector size

Same SSD with 512b sector size
With 512 sector size

@vjr vjr linked a pull request Oct 23, 2021 that will close this issue
Open
@vjr vjr linked a pull request Oct 23, 2021 that will close this issue
Handle disk sector size #621
Open
@vjr vjr added the Priority: Medium Should be addressed when time allows label Apr 20, 2022
@vjr vjr changed the title Support sector sizes other than the current assumed 512 bytes Support non-512-byte sector sizes Apr 20, 2022
@vjr vjr added this to OS 7 Apr 20, 2022
@vjr vjr moved this to Needs Discussion in OS 7 Apr 20, 2022
@vjr vjr changed the title Support non-512-byte sector sizes Installer support for non-512-byte sector sizes Apr 20, 2022
@danirabbit danirabbit removed this from OS 7 Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Should be addressed when time allows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle disk sector size vjr/installer
2 participants
@vjr @dr-Styki