-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer shows incorrect partition sizes, cannot install due to perceived ESP partition size #620
Comments
67 MB is about 1/8th of 512 MB which leads me to believe this is an issue in the installer/distinst not recognising 4k sector sizes? |
I re-ran the above steps this morning and added log output from |
@vjr Interesting. I didn't make the connection, but all of the perceived sizes are about 1/8th, + some offset. I'm assuming there's likely no way for me to work around this in the meantime by somehow explicitly telling the installer about the sector size? |
I had tried working on a PR to support sector sizes a while back but could not test. The code might have changed a but... Maybe if I have time this weekend I can revisit to see if I'm able to make any progress |
@vjr Thanks! I'll keep my machine in this state for now — if you (or someone else) do have time to look into this, I'd be happy to provide any more info, or test out changes. |
@itaiferber I've created a draft PR here: #621 I'll try to test (I dont have a 4k disk) maybe in a VM, but you are free to try my branch if you can. I plan to boot an elementary 6 live ISO, install git and other tools/libraries as mentioned in the branch README notes and build and install the installer executable io.elementary.installer and try to run it. |
@itaiferber I've been able to reproduce the problem with a qemu virtual disk with 4k sector size and also able to successfully install using these two branches: https://github.com/vjr/installer/tree/fix-sector-size I had to also patch the distinst tool/library from the pop-os repos to work around the issue. If you would try it, here are the (convoluted) steps I followed which I've typed from memory, so may not be completely accurate, you'll have to figure out any issues here:
The "erase and install" option is failing, probably need to further patch for the LVM/default case, will do that later. Looking forward to hearing back about your results! |
@vjr Wow, thanks for such quick turnaround on this! I'll give those instructions a shot and let you know what I get. |
@vjr I followed your instructions, and everything appears to have compiled and installed! Issues I ran into:
But, I can confirm that I was able to boot up into elementary using rEFInd and am now setting up a user account. Thanks so much for the help! |
@itaiferber so you have elementary OS installed and working on your mac now??? that's good to hear! i missed the step about switching to the right git branch so edited that comment and also made a mention to not run the installer from the terminal but to run it by clicking the icon in the applications menu which causes a logout and launch of the installer - which perhaps also uses the right permissions which may or may not fix the efibootmgr failure - although i have not been able to verify this myself. i'll continue to look into the failure i am seeing with the default "erase and install" flow (some error about not being able to create LVM partition/volume) maybe its some similar fix to the custom installation flow. |
Yes! There's still a good amount of hardware support I need to figure out, but it is up and running. Thanks again 😄
Ah, should've been clearer about this — this isn't an elementary/installer failure. I haven't found
For what it's worth, before managing the custom install, but with your branches, I did initially hit "Erase and Install" (just to see if it would fail in the usual way) and the installation did appear to actually begin. I didn't actually let it go through because I wanted to test the partitioning scheme, so I'm not sure whether it would have failed somewhere along the way, but at least I didn't immediately hit "Could not Install"... |
I've now filed PR pop-os/distinst#278 to go along with the installer PR #621 if anyone wants to try them out and comment? |
Hello, @vjr ! |
Hello @dinered my bad I deleted the branch after my pr got merged but luckily github has a restore button! Can you do a |
Dear @vjr, first of all, thank you for your blazing fast answer!
Now installer starting, but doesn't show partitions at all. |
OMG, I just found that Odin doesn't support full disk encrypted custom installation, am I right? |
Try adding a & to the daemon command to allow it to return to the command prompt? I'm sorry I'm not familiar with the disk encryption part, maybe you can try the normal install for now and see if it works? Note that elementary v7 is not beta yet, not even alpha level, only the base ubuntu 22.04 is beta so you should avoid it unless you really want to experiment either on your laptop or maybe in a VM. |
@vjr , I did everything again, successful compile new version, now size is ok, but after custom install I had this errors -
|
@dinered yes IIRC i had only done basic 4k block size support which i think doesn't work for logical volumes... can you try either standard install or custom install but create basic ext4 partition? i have a couple of other PRs open (but from a while back) to try better 4k disk sector size support but i have to revisit them later on - in the mean time try a simple installation just to test? |
@vjr , it was already basic ext4 partition. I have to create backup my macos partition to basic install, but i will try. |
@vjr this is standard erase and install
|
Still an issue and can't try #620 (comment) because cannot install elementary-sdk due to unresolved dependencies - depends on libgala-dev, depends on libmutter-6-dev, depends on etc etc etc.... Trying to install "elementary OS 6.1 Jólnir" |
Just happened to me in a 12' inch retina 2015 macbook https://support.apple.com/kb/SP712 |
Hey @vjr, Thanks for all your work on this issue! I have a 2020 MBP and this was a blocker for me trying out PopOS, I went through your original instructions, but came up against a couple of issues along the way so I thought I'd call out where I had trouble and provide updated instructions in case anybody else gives it a go.
In the end, here's what my steps looked like to get things going (with links to my updated forks):
Per other earlier comments, the eftbootbgr fails to update at the end, but it doesn't really matter and you can still boot it (in the case of my Macbook Pro, by holding down the option key on restart and selecting "EFI manager" rather than the Mac startup disk Hope that helps someone! |
@adamd9 this is good stuff, thanks for the updates! |
If you boot the ISO with This bug although has been fixed in newer kernels and Linux can now set boot partitions. |
Hello there! I recently attempted to install Pop!_OS and had to use your guide to fix the installer, and I'd like to leave the list of commands which worked for me here, which is a bit different from yours.
|
This is STILL a problem with the latest image nearly 2 years later? I take it elementaryOS project is dead..? |
Hi, I think I have the same problem as was mentioned here with newest Elementary OS https://github.com/orgs/elementary/discussions/494#discussion-6413044 I tried everything mentioned in this post and nothing has worked. Am I right that it's the same issue? Or is it new issue? Thanks in advance for any help, I am desperate. |
What Happened?
Attempting to install elementary OS 6 fails on my 2019 MacBook Pro, seemingly due to not being able to correctly read partition sizes on the disk. Attempting to install on this machine via the default "Erase Disk and Install" option fails with a "Installing elementary OS 6 Odin failed, possibly due to a hardware error." message, and attempting a "Custom Install" does not allow me to continue.
Steps to Reproduce
Screenshot
Screenshot
Screenshot
Screenshot
I've confirmed that booting into Demo Mode on the same drive shows the right partition sizes in GParted, as does booting into a GParted live USB.
Expected Behavior
OS Version
6.x (Odin) [
elementaryos-6.0-stable.20211005
]Software Version
Latest release (I have run all updates)
Log Output
I re-ran the above steps as-is (including recreating all partitions) this morning (the day after submission) and grabbed
journalctl
output from demo mode: journal.logHardware Info
This is on a 2019 MBP with a 1 TB internal drive and SIP and Secure Boot previously disabled.
The text was updated successfully, but these errors were encountered: