Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicNotebook: Padding and border around Gtk.EventBox #523

Closed
felix-andreas opened this issue Jul 6, 2019 · 2 comments · May be fixed by #763
Closed

DynamicNotebook: Padding and border around Gtk.EventBox #523

felix-andreas opened this issue Jul 6, 2019 · 2 comments · May be fixed by #763
Assignees
@danirabbit

Comments

@felix-andreas
Copy link
Member

felix-andreas commented Jul 6, 2019 •
edited
Loading

Conversation from elementary/granite#295:

@andreasfelix Definitely better than before! It still happens when I double-wheelclick on the border between two tabs, though. Do you think this is can/should be fixed within the same PR?

Originally posted by @jlnr in elementary/granite#295 (comment)

Unfortunately I think this is a different Issue. I have highlighted the size of the GranitsWidgetsTab and logged the enter and leave events:

Border_event

As one can see, the size of the GranitsWidgetsTab is slightly smaller than its visual size. This can also be seen at the event log: The signal get emitted when entering/leaving the blue highlighted area. When clicking on a Tab outside of this are, the signal gets directly passed to DynamicNotebook which leads to the restoring of the last closed tab.

I think this is related to the padding and border in the style sheet:

stylesheet/elementary/gtk-3.0/gtk-widgets.css

Lines 1670 to 1688 in ec23fec

notebook tab {
background-image: none;
background-color: transparent;
border-image:
linear-gradient(
to bottom,
transparent,
alpha (
#000,
0.2
)
) 0 1 0 0;
border-radius: 0;
border-style: solid;
border-width: 0 1px;
color: shade (@text_color, 1.12);
margin-right: -1px;
padding: 3px;
}

Maybe it could be solved by changing notebook tab to notebook tab widgets grid, so the padding is within the Gtk.EventBox.

Originally posted by @andreasfelix in elementary/granite#295 (comment)
@felix-andreas
Copy link
Member Author

felix-andreas commented Jul 6, 2019 •
edited
Loading

I changed the style in the Inspector and I think this would actually fix the problem.

Before:
Event_box_padding

After:
GTK BOX

@felix-andreas felix-andreas mentioned this issue Jul 10, 2019
Closed
@felix-andreas felix-andreas mentioned this issue Jul 12, 2020
Open
@danirabbit
Copy link
Member

Gonna close this since DynamicNotebook has been deprecated

@danirabbit danirabbit closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danirabbit danirabbit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notebook Tabs: move padding to grid felix-andreas/stylesheet
2 participants
@danirabbit @felix-andreas