-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass Do Not Disturb #84
base: master
Are you sure you want to change the base?
Conversation
This seems like something that would require a new panel around what DnD means for you and what it should do (like the new iOS 15 DnD rule settings) |
TL;DR I don't think we can nor do I think we should mimic what Apple is doing here - at least for now. @hanaral don't get me wrong, the iOS 15 FOCUS stuff looks indeed interesting. But if we want something like this, we would need a lot more fine grained controls in place than we have right now. This would either lead to a lot of options for the user or - even worse - forces us to gather lots of data from them (even if only on device). If I understand it correctly, Apple allows to only get notifications from "Friends" when in "Private" mood - wherelse when we are in "Work" mood, it allows notifications from co-workers as well. Even if we not do this on a person level, we would still need a way categorize notifications per app (e.g. per contact group, per mail account, ... - and then somehow define which of those are "Work" or "Private"). If we don't go this route, we would simply end up with multiple "Do Not Disturb - but allow this app" profiles. In this case, the user is only capable to allow an app to completely bypass DnD or not - and store this piece of configuration to quickly switch between such profiles. So its basically just a convenience extension to what I'm proposing here. However, I don't really see the added value of having multiple profiles, cause I don't have that much of different scenarios where "I don't want to be disturbed - but allow this app" applies 🤷 |
I'm gonna bump this to OS 7 because I think we need more careful consideration around the design here than we have this month |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works as expected.
There is some commented out code.
This seems to match the currently preferred UI in the issue.
Fixes #29. Needs elementary/notifications#148 to work.