From c81d6cc89614f9ab8610192e401918a1a360720a Mon Sep 17 00:00:00 2001 From: bedroesb Date: Sun, 29 Oct 2023 14:19:15 +0100 Subject: [PATCH] use octicon --- Gemfile | 25 ++++++++++++----------- _config.yml | 1 + _sass/_custom_classes.scss | 4 ++++ images/octicon:file-diff.svg | 1 - pages/contribute/editorial_board_guide.md | 2 +- 5 files changed, 19 insertions(+), 14 deletions(-) delete mode 100644 images/octicon:file-diff.svg diff --git a/Gemfile b/Gemfile index fc655a3a0..dd2b1788d 100644 --- a/Gemfile +++ b/Gemfile @@ -1,17 +1,18 @@ -source "https://rubygems.org" +source 'https://rubygems.org' -gem "elixir-toolkit-theme-plugins", "~> 0.1.9" -gem "webrick", "~> 1.7" -gem "jekyll", "~> 4.3.1" -gem "jemoji", "~> 0.13.0" -gem "kramdown-parser-gfm", "~> 1.1" +gem 'elixir-toolkit-theme-plugins', '~> 0.1.9' +gem 'webrick', '~> 1.7' +gem 'jekyll', '~> 4.3.1' +gem 'jemoji', '~> 0.13.0' +gem 'kramdown-parser-gfm', '~> 1.1' +gem 'jekyll-octicons' group :jekyll_plugins do - gem "jekyll-redirect-from", "~> 0.16.0" - gem "jekyll-sitemap", "~> 1.4" - gem "jekyll-github-metadata", "~> 2.15" - gem "jekyll-relative-links", "~> 0.6" - gem "jekyll-seo-tag", "~> 2.8" - gem "jekyll-remote-theme" + gem 'jekyll-redirect-from', '~> 0.16.0' + gem 'jekyll-sitemap', '~> 1.4' + gem 'jekyll-github-metadata', '~> 2.15' + gem 'jekyll-relative-links', '~> 0.6' + gem 'jekyll-seo-tag', '~> 2.8' + gem 'jekyll-remote-theme' end diff --git a/_config.yml b/_config.yml index 3d652e9b2..087de2148 100644 --- a/_config.yml +++ b/_config.yml @@ -141,3 +141,4 @@ plugins: - jekyll-redirect-from - jekyll-sitemap - jekyll-github-metadata + - jekyll-octicons diff --git a/_sass/_custom_classes.scss b/_sass/_custom_classes.scss index bf4cbbe5c..ffbfe354b 100644 --- a/_sass/_custom_classes.scss +++ b/_sass/_custom_classes.scss @@ -26,6 +26,10 @@ } +.octicon { + margin-right: 0.25em; +} + /*-----Sidebar-----*/ //RDM wheel in sidebar diff --git a/images/octicon:file-diff.svg b/images/octicon:file-diff.svg deleted file mode 100644 index 6b9569cc0..000000000 --- a/images/octicon:file-diff.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/pages/contribute/editorial_board_guide.md b/pages/contribute/editorial_board_guide.md index d027a9b83..110e15aaf 100644 --- a/pages/contribute/editorial_board_guide.md +++ b/pages/contribute/editorial_board_guide.md @@ -44,7 +44,7 @@ More information about these topics can be found in the GitHub documentation: ## Review pull requests -If contributors make a pull request to make changes, by default the editors that are responsible for files that will be changed by the PR will be assigned and notified. All PR should be assigned to one of the editors. The use of the suggestion for specific changes to the line or lines (by clicking {% include image.html file="octicon:file-diff.svg" inline=true alt="Raw button GitHub." %} in the comment field) For more infomration about this please visit the [GitHub documentation page: starting a review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review). +If contributors make a pull request to make changes, by default the editors that are responsible for files that will be changed by the PR will be assigned and notified. All PR should be assigned to one of the editors. The use of the suggestion for specific changes to the line or lines (by clicking {% octicon file-diff height:16 %}in the comment field) For more infomration about this please visit the [GitHub documentation page: starting a review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review). Before merging a PR, pages' tags, and tools and resources' tags should be checked and assigned according to the established tagging system. The editor who provides the last approval to a PR should also merge it.