v0.15.0 breaks syntax highlighting

[ryanwinchester]

See images.

Before update

After update

[eulixir]

It is worth pointing out that this color induces one to think that there is something wrong in the syntax

[NobbZ]

I have massive problems with "doc-comments" not beeing closed ever…

Sorry for the crop, but I have to be careful with sensitive code.

In the output-panes "window" log I can see the follwing traces:

2023-06-20 16:03:15.998 [error] an exception was raised:
    ** (CaseClauseError) no case clause matching: nil
        (elixir_sense 2.0.0) lib/elixir_sense/providers/docs.ex:58: ElixirSense.Providers.Docs.mod_fun_docs/9
        (elixir_sense 2.0.0) lib/elixir_sense.ex:74: ElixirSense.docs/3
        (language_server 0.15.0) lib/language_server/providers/hover.ex:24: ElixirLS.LanguageServer.Providers.Hover.hover/4
        (language_server 0.15.0) lib/language_server/server.ex:828: anonymous fn/3 in ElixirLS.LanguageServer.Server.handle_request_async/2: Error: an exception was raised:
    ** (CaseClauseError) no case clause matching: nil
        (elixir_sense 2.0.0) lib/elixir_sense/providers/docs.ex:58: ElixirSense.Providers.Docs.mod_fun_docs/9
        (elixir_sense 2.0.0) lib/elixir_sense.ex:74: ElixirSense.docs/3
        (language_server 0.15.0) lib/language_server/providers/hover.ex:24: ElixirLS.LanguageServer.Providers.Hover.hover/4
        (language_server 0.15.0) lib/language_server/server.ex:828: anonymous fn/3 in ElixirLS.LanguageServer.Server.handle_request_async/2
	at handleResponse (/Users/norbert.melzer/.vscode/extensions/jakebecker.elixir-ls-0.15.0/node_modules/vscode-jsonrpc/lib/common/connection.js:565:48)
	at handleMessage (/Users/norbert.melzer/.vscode/extensions/jakebecker.elixir-ls-0.15.0/node_modules/vscode-jsonrpc/lib/common/connection.js:345:13)
	at processMessageQueue (/Users/norbert.melzer/.vscode/extensions/jakebecker.elixir-ls-0.15.0/node_modules/vscode-jsonrpc/lib/common/connection.js:362:17)
	at Immediate.<anonymous> (/Users/norbert.melzer/.vscode/extensions/jakebecker.elixir-ls-0.15.0/node_modules/vscode-jsonrpc/lib/common/connection.js:334:13)
	at process.processImmediate (node:internal/timers:466:21)

NB: Only a couple of files seem to be affected, and after the first @doc things are usually still correct, only after the second or third things get weird.

[eulixir]

I am having the same problem @NobbZ, for now I will use the latest "stable" version of extension and keep an eye on the bugfix.

[aj-foster]

Similar to phoenixframework/vscode-phoenix#19, this looks like an interaction between the grammar and VS Code's built-in bracket pair colorization feature.

Specifically, this commit introduced ["do:", " "] to the brackets configuration, which appears to be invalid.

[lukaszsamson]

In the output-panes "window" log I can see the following traces

This is harmless

Specifically, this commit introduced ["do:", " "] to the brackets configuration, which appears to be invalid.

I will have to revert it. My intention was to match do: with a whitespace next to it and create a closed pair. It seems that is not working correctly.

[aj-foster]

Regarding docstring highlighting that does not terminate, it appears to occur (for me) when a list is present in the markdown of the docstring. Removing the - or * of list items makes the markdown context end with the """ correctly.

[lukaszsamson]

Having brackets like this

"brackets": [
    ["{", "}"],
    ["[", "]"],
    ["(", ")"],
    ["<<", ">>"],
    ["do", ":"],
    ["do", "end"],
    ["fn", "end"]
  ]

fixes that case

but it makes do match with first : in the block. After looking though the docs and issues on vscode repo it's not possible to use regex nor negative matches in the bracket definition.

[Danichyo]

I have a problem with @moduledoc syntax highlighting and nested modules. If @moduledoc is in a nested module, the syntax highlighting is broken

OK:

NOT OK:

[maxguzenski]

inline IF (or WITH, etc) is broken as well.

[lukaszsamson]

I had to remove markdown highlighting in heredocs. It interfered with elixir grammar and I couldn't find a workaround.
I believe all the issues are now fixed.